Skip to content

Fix CVT override with full coverage #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Fix CVT override with full coverage #345

merged 2 commits into from
Dec 17, 2022

Conversation

jmthomas
Copy link
Member

No description provided.

@jmthomas jmthomas requested a review from ryanmelt December 17, 2022 18:34
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Base: 74.95% // Head: 74.96% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5391d38) compared to base (080696c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   74.95%   74.96%           
=======================================
  Files         446      446           
  Lines       27186    27187    +1     
  Branches      578      578           
=======================================
+ Hits        20378    20380    +2     
+ Misses       6717     6716    -1     
  Partials       91       91           
Flag Coverage Δ
frontend 75.77% <ø> (+0.04%) ⬆️
ruby-api 50.43% <ø> (ø)
ruby-backend 79.26% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/models/cvt_model.rb 100.00% <100.00%> (+1.72%) ⬆️
openc3/lib/openc3/utilities/metric.rb 90.19% <0.00%> (-5.89%) ⬇️
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 71.49% <0.00%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit 458fc57 into main Dec 17, 2022
@jmthomas jmthomas deleted the cvt_override branch December 17, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant