Skip to content

Don't filter scripts to lib and procedures #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Don't filter scripts to lib and procedures #335

merged 1 commit into from
Dec 13, 2022

Conversation

jmthomas
Copy link
Member

closes #333

@jmthomas jmthomas requested a review from ryanmelt December 13, 2022 19:19
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 74.98% // Head: 75.02% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (53e198e) compared to base (626b5c6).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   74.98%   75.02%   +0.03%     
==========================================
  Files         447      447              
  Lines       27166    27167       +1     
  Branches      578      578              
==========================================
+ Hits        20371    20382      +11     
+ Misses       6703     6694       -9     
+ Partials       92       91       -1     
Flag Coverage Δ
frontend 75.73% <ø> (+0.14%) ⬆️
ruby-api 50.66% <0.00%> (ø)
ruby-backend 79.30% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...enc3-cosmos-script-runner-api/app/models/script.rb 20.00% <0.00%> (ø)
openc3/lib/openc3/utilities/local_mode.rb 100.00% <100.00%> (ø)
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 71.19% <0.00%> (-0.30%) ⬇️
openc3/lib/openc3/utilities/metric.rb 96.07% <0.00%> (+5.88%) ⬆️
...smos-tool-calendar/src/tools/Calendar/Calendar.vue 72.29% <0.00%> (+6.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt merged commit ab89c91 into main Dec 13, 2022
@ryanmelt ryanmelt deleted the script_filter branch December 13, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCRIPT RUNNER: Add the ability to see more than just "lib" and "procedures"
2 participants