Skip to content

Reducer nil checks #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Reducer nil checks #329

merged 1 commit into from
Dec 13, 2022

Conversation

ryanmelt
Copy link
Member

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas December 12, 2022 23:39
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 74.94% // Head: 74.94% // No change to project coverage 👍

Coverage data is based on head (c3064d6) compared to base (ce6b926).
Patch coverage: 94.44% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files         447      447           
  Lines       27145    27145           
  Branches      578      578           
=======================================
  Hits        20345    20345           
  Misses       6709     6709           
  Partials       91       91           
Flag Coverage Δ
frontend 75.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...3/lib/openc3/microservices/reducer_microservice.rb 93.35% <94.44%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt merged commit 523080b into main Dec 13, 2022
@ryanmelt ryanmelt deleted the reducer_nil_checks branch December 13, 2022 05:24
Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good check but how are these reads of the RAW values producing nils?

@ryanmelt
Copy link
Member Author

Need minio console fixed so I can inspect the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants