Skip to content

Fix xtce_converter #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Fix xtce_converter #219

merged 3 commits into from
Oct 21, 2022

Conversation

jmthomas
Copy link
Member

closes #207

@jmthomas jmthomas requested a review from ryanmelt October 19, 2022 22:13
@jmthomas
Copy link
Member Author

Sample output:

jmthomas@Jasons-MacBook-Air-2 openc3 % ./openc3.sh cli xtce_converter --plugin openc3-demo-1.0.0.gem --output output2                        
Installing openc3-demo-1.0.0.gem
Converting target INST to .xtce files in output2/INST
Converting target INST2 to .xtce files in output2/INST2
Converting target EXAMPLE to .xtce files in output2/EXAMPLE
Converting target TEMPLATED to .xtce files in output2/TEMPLATED
Converting target SYSTEM to .xtce files in output2/SYSTEM
/usr/local/lib/site_ruby/3.1.0/rubygems/uninstaller.rb:98:in `uninstall': gem "openc3-demo" is not installed (Gem::InstallError)
    from /openc3/bin/openc3cli:261:in `xtce_converter'
    from /openc3/bin/openc3cli:518:in `<main>'
Uninstalling openc3-demo, version 1.0.0

Not sure if I should just remove the uninstall logic or not

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 74.18% // Head: 74.15% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (49c8815) compared to base (9ed3c5a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   74.18%   74.15%   -0.03%     
==========================================
  Files         416      416              
  Lines       25662    25662              
  Branches      562      562              
==========================================
- Hits        19037    19030       -7     
- Misses       6540     6549       +9     
+ Partials       85       83       -2     
Flag Coverage Δ
frontend 75.43% <ø> (-0.09%) ⬇️
ruby-api 44.04% <ø> (ø)
ruby-backend 78.70% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/utilities/metric.rb 90.19% <0.00%> (-5.89%) ⬇️
...enc3-tool-calendar/src/tools/Calendar/Calendar.vue 61.37% <0.00%> (-5.52%) ⬇️
...blemanager/src/tools/TableManager/TableManager.vue 72.77% <0.00%> (-1.05%) ⬇️
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 71.78% <0.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openc3cli: xtce_converter not calling install_phase1/2 with correct arguments
1 participant