Skip to content

Button tweaks #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2025
Merged

Button tweaks #2031

merged 6 commits into from
Apr 24, 2025

Conversation

ryan-pratt
Copy link
Contributor

  • Replaced the last of the clickable icons (I think) with icon buttons
  • Better use of v-btn's API wrt text and icons
  • Tweaked Script Runner's environment button because it was super unclear to me what it was. I thought it was a script bookmarking feature until I looked at the code. I also changed it to use a badge to indicate that the environment is modified, rather than just changing the color.
image

I did this with Claude, and its context isn't big enough to go through
the whole codebase, but this is a start.
@ryan-pratt ryan-pratt requested a review from jmthomas April 19, 2025 01:08
Copy link

codecov bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (d851767) to head (e05b797).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
- Coverage   76.86%   76.85%   -0.01%     
==========================================
  Files         638      638              
  Lines       47435    47438       +3     
  Branches      750      750              
==========================================
- Hits        36459    36458       -1     
- Misses      10893    10897       +4     
  Partials       83       83              
Flag Coverage Δ
python 83.95% <ø> (-0.04%) ⬇️
ruby-api 48.30% <ø> (ø)
ruby-backend 82.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryan-pratt ryan-pratt marked this pull request as ready for review April 19, 2025 02:31
Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new icon ... seems like a good choice: mdi-application-variable.

The ScriptEnvironmentDialog is messed up ... the Value field is squished and the delete icon isn't aligned:
Screenshot 2025-04-19 at 10 06 47 AM

@@ -51,13 +51,15 @@
icon="mdi-notification-clear-all "
variant="text"
data-test="clear-notifications"
aria-label="Clear All Notifications"
@click="clearNotifications"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we just cleaned up all the unnecessary notifications but this triple line icon I think could use a tooltip ... it's not immediately obvious to me what it does and when you click it all the notifications go poof.

@jmthomas
Copy link
Member

jmthomas commented Apr 21, 2025

Admin console Plugin buttons also got a bunch more space:
Screenshot 2025-04-21 at 8 58 46 AM

@ryan-pratt ryan-pratt requested a review from jmthomas April 21, 2025 18:31
@jmthomas
Copy link
Member

Please fix the layout on this env dialog so the values aren't squished:
Screenshot 2025-04-23 at 8 36 01 AM

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once you get the env dialog layout a little better :-)

@ryan-pratt
Copy link
Contributor Author

image

Copy link

@ryan-pratt ryan-pratt merged commit f944acf into main Apr 24, 2025
30 checks passed
@ryan-pratt ryan-pratt deleted the feat/aria-labels branch April 24, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants