-
Notifications
You must be signed in to change notification settings - Fork 42
Button tweaks #2031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button tweaks #2031
Conversation
ryan-pratt
commented
Apr 19, 2025
- Replaced the last of the clickable icons (I think) with icon buttons
- Better use of v-btn's API wrt text and icons
- Tweaked Script Runner's environment button because it was super unclear to me what it was. I thought it was a script bookmarking feature until I looked at the code. I also changed it to use a badge to indicate that the environment is modified, rather than just changing the color.

I did this with Claude, and its context isn't big enough to go through the whole codebase, but this is a start.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
==========================================
- Coverage 76.86% 76.85% -0.01%
==========================================
Files 638 638
Lines 47435 47438 +3
Branches 750 750
==========================================
- Hits 36459 36458 -1
- Misses 10893 10897 +4
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -51,13 +51,15 @@ | |||
icon="mdi-notification-clear-all " | |||
variant="text" | |||
data-test="clear-notifications" | |||
aria-label="Clear All Notifications" | |||
@click="clearNotifications" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we just cleaned up all the unnecessary notifications but this triple line icon I think could use a tooltip ... it's not immediately obvious to me what it does and when you click it all the notifications go poof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved once you get the env dialog layout a little better :-)
|