Skip to content

Add details dialog to LedWidget #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Add details dialog to LedWidget #1993

merged 1 commit into from
Apr 2, 2025

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Apr 1, 2025

closes #1988

@jmthomas jmthomas requested review from ryan-pratt and ryanmelt April 1, 2025 21:21
@jmthomas
Copy link
Member Author

jmthomas commented Apr 1, 2025

Screenshot 2025-04-01 at 3 20 44 PM

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.83%. Comparing base (ceca49c) to head (e901e66).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1993      +/-   ##
==========================================
- Coverage   76.85%   76.83%   -0.02%     
==========================================
  Files         629      629              
  Lines       47000    47000              
  Branches      755      755              
==========================================
- Hits        36120    36111       -9     
- Misses      10797    10806       +9     
  Partials       83       83              
Flag Coverage Δ
python 84.07% <ø> (-0.05%) ⬇️
ruby-api 48.30% <ø> (ø)
ruby-backend 82.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthomas jmthomas merged commit f54fdcc into main Apr 2, 2025
29 of 30 checks passed
@jmthomas jmthomas deleted the led_details branch April 2, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right click LED widget for Details & Graph
2 participants