Skip to content

Fix bug in confirm dialog with validation text #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Conversation

ryan-pratt
Copy link
Contributor

If you opened a dialog where you inputted validation text, subsequent non-validation-text dialogs on that page wouldn't work

If you opened a dialog where you inputted validation text, subsequent
non-validation-text dialogs on that page wouldn't work
@ryan-pratt ryan-pratt requested a review from jmthomas March 31, 2025 19:33
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.87%. Comparing base (a9a3e37) to head (b85badc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
+ Coverage   76.85%   76.87%   +0.01%     
==========================================
  Files         629      629              
  Lines       46929    46929              
  Branches      755      755              
==========================================
+ Hits        36068    36075       +7     
+ Misses      10778    10771       -7     
  Partials       83       83              
Flag Coverage Δ
python 84.14% <ø> (+0.04%) ⬆️
ruby-api 48.48% <ø> (ø)
ruby-backend 82.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses issue with no validation text

@ryan-pratt ryan-pratt merged commit bd39b3e into main Mar 31, 2025
29 of 30 checks passed
@ryan-pratt ryan-pratt deleted the bug/confirm-dialog branch March 31, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants