Skip to content

Set received count in interface_microservice and inject_tlm #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2022

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Oct 6, 2022

closes #196
closes #183

@jmthomas jmthomas requested a review from ryanmelt October 6, 2022 19:28
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 74.00% // Head: 74.09% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (7af7b1b) compared to base (febdcf2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   74.00%   74.09%   +0.09%     
==========================================
  Files         413      413              
  Lines       25567    25592      +25     
  Branches      559      559              
==========================================
+ Hits        18920    18963      +43     
+ Misses       6561     6544      -17     
+ Partials       86       85       -1     
Flag Coverage Δ
frontend 75.75% <ø> (+0.14%) ⬆️
ruby-api 43.91% <ø> (ø)
ruby-backend 78.60% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/api/tlm_api.rb 95.34% <100.00%> (+0.11%) ⬆️
...lib/openc3/microservices/interface_microservice.rb 84.27% <100.00%> (+0.30%) ⬆️
...smonitor/src/tools/LimitsMonitor/LimitsControl.vue 81.48% <0.00%> (-0.75%) ⬇️
...enc3-tool-calendar/src/tools/Calendar/Calendar.vue 71.03% <0.00%> (+5.51%) ⬆️
openc3/lib/openc3/operators/operator.rb 58.01% <0.00%> (+10.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use Topics instead of CVT. But also it may be ok as is. Just think about it.

# TODO: New packet so received_count is not correct
packet.received_count += 1
begin
packet.received_count = CvtModel.get_item(target_name, packet_name, "RECEIVED_COUNT", type: :CONVERTED, scope: scope) + 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should pull from the last message in the Raw topic? That would be the most recent received_count. There will always be a race condition with this, but the CVT doesn't get updated until after decom, so for high rate packets this will probably be behind. (But then for high rate packets why are you using inject_tlm). Don't know.

@jmthomas jmthomas merged commit b4b63db into master Oct 7, 2022
@jmthomas jmthomas deleted the packet_count branch October 7, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Received count on inject_tlm Packet count resets
2 participants