-
Notifications
You must be signed in to change notification settings - Fork 42
Set received count in interface_microservice and inject_tlm #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 74.00% // Head: 74.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 74.00% 74.09% +0.09%
==========================================
Files 413 413
Lines 25567 25592 +25
Branches 559 559
==========================================
+ Hits 18920 18963 +43
+ Misses 6561 6544 -17
+ Partials 86 85 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use Topics instead of CVT. But also it may be ok as is. Just think about it.
openc3/lib/openc3/api/tlm_api.rb
Outdated
# TODO: New packet so received_count is not correct | ||
packet.received_count += 1 | ||
begin | ||
packet.received_count = CvtModel.get_item(target_name, packet_name, "RECEIVED_COUNT", type: :CONVERTED, scope: scope) + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should pull from the last message in the Raw topic? That would be the most recent received_count. There will always be a race condition with this, but the CVT doesn't get updated until after decom, so for high rate packets this will probably be behind. (But then for high rate packets why are you using inject_tlm). Don't know.
closes #196
closes #183