Initial Base Changes to Support Notebooks #1964
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1964 +/- ##
==========================================
+ Coverage 76.68% 76.87% +0.18%
==========================================
Files 628 629 +1
Lines 46637 46737 +100
Branches 755 755
==========================================
+ Hits 35765 35929 +164
+ Misses 10789 10725 -64
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -115,6 +115,9 @@ export class ConfigParserService { | |||
| let line = lines[i].trim() | |||
| // Ensure the line length is not 0 | |||
| if (line.length === 0) { | |||
| if (yield_non_keyword_lines) { | |||
| handler(null, [], this.line, this.lineNumber) | |||
| } | |||
There was a problem hiding this comment.
I needed this functionality for Notebooks. It was in the Ruby/Python versions but not in Javascript
| </splitpanes> | ||
| </div> | ||
|
|
||
| <div v-if="inline"> |
There was a problem hiding this comment.
Doesn't really make sense to support Test Runner inline I guess.
There was a problem hiding this comment.
Correct. Too much chrome and not necessary for notebooks.
| @@ -937,7 +1007,7 @@ export default { | |||
|
|
|||
| // Make NEW_FILENAME available to the template | |||
| this.NEW_FILENAME = NEW_FILENAME | |||
| window.onbeforeunload = this.unlockFile | |||
| //window.onbeforeunload = this.unlockFile | |||
There was a problem hiding this comment.
Doesn't work with multiple script runners on the same page. Also, global actions like this are bad. Should be handled by the unmount lifecycle hook.
|
Primarily adds an inline mode to ScriptRunner so it can be embedded