Skip to content

Stale indicator #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Stale indicator #195

merged 4 commits into from
Oct 6, 2022

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Oct 5, 2022

closes #185

@jmthomas jmthomas requested a review from ryanmelt October 5, 2022 23:30
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 74.01% // Head: 74.03% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (b767d43) compared to base (a856125).
Patch coverage: 76.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   74.01%   74.03%   +0.02%     
==========================================
  Files         413      413              
  Lines       25564    25567       +3     
  Branches      560      559       -1     
==========================================
+ Hits        18920    18929       +9     
+ Misses       6558     6553       -5     
+ Partials       86       85       -1     
Flag Coverage Δ
frontend 75.80% <0.00%> (+0.12%) ⬆️
ruby-api 43.91% <ø> (ø)
ruby-backend 78.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cketviewer/src/tools/PacketViewer/PacketViewer.vue 93.44% <ø> (ø)
...ool-tlmviewer/src/tools/TlmViewer/Openc3Screen.vue 76.35% <0.00%> (-2.03%) ⬇️
openc3/lib/openc3/api/tlm_api.rb 95.23% <100.00%> (ø)
openc3/lib/openc3/models/cvt_model.rb 100.00% <100.00%> (ø)
...enc3-tool-calendar/src/tools/Calendar/Calendar.vue 71.72% <0.00%> (+6.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt
Copy link
Member

ryanmelt commented Oct 6, 2022

Do you think this should use PACKET_TIMESECONDS or RECEIVED_TIMESECONDS. ie. is staleness from packet generation or packet received by COSMOS?

@ryanmelt
Copy link
Member

ryanmelt commented Oct 6, 2022

Seems like it should probably be from RECEIVED_TIMESECONDS.

@jmthomas
Copy link
Member Author

jmthomas commented Oct 6, 2022

Seems like it should probably be from RECEIVED_TIMESECONDS.

I thought about it and couldn't decide. In general we use PACKET_TIMESECONDS because that's where we allow conversions and let users generate it based on their own timestamp. But I think in this case it's more about the staleness with respect to being RECEIVED by OpenC3 so I'll change it.

@jmthomas jmthomas merged commit febdcf2 into master Oct 6, 2022
@jmthomas jmthomas deleted the stale_indicator branch October 6, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale telemetry indication
2 participants