Skip to content

Support 64 bit ints in CommandSender #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2025
Merged

Support 64 bit ints in CommandSender #1930

merged 2 commits into from
Mar 1, 2025

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Feb 28, 2025

closes #1928
closes #1931

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.69%. Comparing base (ba1c21a) to head (bbe5893).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
- Coverage   76.73%   76.69%   -0.04%     
==========================================
  Files         628      628              
  Lines       46644    46643       -1     
  Branches      756      755       -1     
==========================================
- Hits        35790    35774      -16     
- Misses      10771    10786      +15     
  Partials       83       83              
Flag Coverage Δ
python 84.13% <ø> (-0.09%) ⬇️
ruby-api 48.39% <ø> (ø)
ruby-backend 82.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lossless-json for the win!

@jmthomas jmthomas merged commit 802ea9b into main Mar 1, 2025
30 checks passed
@jmthomas jmthomas deleted the bigint branch March 1, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PacketViewer precision issue with big ints CmdSender precision issue with UINT64 parameter
2 participants