Skip to content

Handle news connection failure #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Handle news connection failure #1920

merged 2 commits into from
Feb 27, 2025

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Feb 25, 2025

closes #1919

@jmthomas jmthomas requested a review from ryanmelt February 25, 2025 06:07
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (41264af) to head (ba1c21a).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/api/settings_api.rb 0.00% 2 Missing ⚠️
openc3/lib/openc3/models/news_model.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
+ Coverage   76.69%   76.73%   +0.03%     
==========================================
  Files         628      628              
  Lines       46637    46644       +7     
  Branches      756      756              
==========================================
+ Hits        35770    35790      +20     
+ Misses      10784    10771      -13     
  Partials       83       83              
Flag Coverage Δ
python 84.22% <ø> (+0.08%) ⬆️
ruby-api 48.39% <ø> (ø)
ruby-backend 82.60% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryan-pratt
Copy link
Contributor

Shows in here rather than a yellow warning banner

image

@jmthomas jmthomas merged commit c0823f8 into main Feb 27, 2025
30 checks passed
@jmthomas jmthomas deleted the news branch February 27, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

News Feed Not Loading Causes Microservice Crash, and Error Bar in Browser Apps
2 participants