Add params to connect_interface #192
Conversation
|
Note this isn't quite working yet. It has somehow broken connecting the EXAMPLE and TEMPLATED interfaces. It appears the connect method thinks the interface name is a parameter and is then trying to pass that through to the constructor. I think the issue is with the Javascript but still debugging. |
Codecov ReportBase: 73.79% // Head: 74.01% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 73.79% 74.01% +0.21%
==========================================
Files 413 413
Lines 25551 25564 +13
Branches 560 560
==========================================
+ Hits 18855 18920 +65
+ Misses 6611 6558 -53
- Partials 85 86 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -119,8 +119,8 @@ export class OpenC3Api { | |||
| return this.exec('map_target_to_interface', [target_name, interface_name]) | |||
| } | |||
|
|
|||
| connect_interface(interface_name) { | |||
| return this.exec('connect_interface', [interface_name]) | |||
| connect_interface(interface_name, interface_params) { | |||
There was a problem hiding this comment.
interface_params should default to nil or an empty array
There was a problem hiding this comment.
Null? this is the javascript side. This is the part I wasn't sure about. I think probably an empty array.
closes #177