Skip to content

Command validator returns true, false, nil #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Command validator returns true, false, nil #1561

merged 1 commit into from
Sep 24, 2024

Conversation

jmthomas
Copy link
Member

No description provided.

@jmthomas jmthomas requested a review from ryanmelt September 22, 2024 02:59
Copy link

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.04%. Comparing base (5e4b7a0) to head (39ea57f).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...lib/openc3/microservices/interface_microservice.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
+ Coverage   77.02%   77.04%   +0.01%     
==========================================
  Files         611      611              
  Lines       46000    46000              
  Branches      800      800              
==========================================
+ Hits        35431    35440       +9     
+ Misses      10481    10474       -7     
+ Partials       88       86       -2     
Flag Coverage Δ
frontend 55.87% <ø> (+0.08%) ⬆️
python 84.63% <ø> (+0.02%) ⬆️
ruby-api 48.85% <ø> (ø)
ruby-backend 82.81% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit 6b0782d into main Sep 24, 2024
27 checks passed
@jmthomas jmthomas deleted the validator branch September 24, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants