Skip to content

Fix applying subsettings, fix LimitscolumnWidget #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2024
Merged

Fix applying subsettings, fix LimitscolumnWidget #1401

merged 2 commits into from
Jul 14, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Jul 13, 2024

closes #1389

@jmthomas jmthomas requested a review from ryanmelt July 13, 2024 19:46
@jmthomas
Copy link
Member Author

Screenshot 2024-07-13 at 1 42 30 PM

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.38%. Comparing base (c85245c) to head (2d484c0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
- Coverage   75.40%   75.38%   -0.02%     
==========================================
  Files         600      600              
  Lines       44701    44700       -1     
  Branches      777      777              
==========================================
- Hits        33705    33699       -6     
- Misses      10908    10913       +5     
  Partials       88       88              
Flag Coverage Δ
frontend 55.36% <ø> (-0.02%) ⬇️
python 83.97% <ø> (-0.04%) ⬇️
ruby-api 48.60% <ø> (ø)
ruby-backend 80.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Playwright passes on next run.

@ryanmelt
Copy link
Member

Same playwright failure twice in a row

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix playwright

Copy link

@jmthomas jmthomas merged commit 3868a2d into main Jul 14, 2024
26 checks passed
@jmthomas jmthomas deleted the subsettings branch July 14, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limits Example Screen Issues
2 participants