Skip to content

add more typing to python models code #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 23, 2024

Conversation

GerhardOfRivia
Copy link
Contributor

No description provided.

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.08%. Comparing base (470320c) to head (e4e8515).
Report is 35 commits behind head on main.

Current head e4e8515 differs from pull request most recent head d9ad883

Please upload reports for the commit d9ad883 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1234       +/-   ##
===========================================
+ Coverage   55.21%   75.08%   +19.86%     
===========================================
  Files         103      357      +254     
  Lines        5455    27478    +22023     
  Branches      759      759               
===========================================
+ Hits         3012    20631    +17619     
- Misses       2360     6764     +4404     
  Partials       83       83               
Flag Coverage Δ
ruby-backend 80.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas
Copy link
Member

jmthomas commented May 4, 2024

@GerhardOfRivia thanks for the PR! Please fix the Python linter errors.

@jmthomas
Copy link
Member

@GerhardOfRivia poetry looks interesting but we'll have to make sure the way it manages environments works well with the new Alpine 3.19.0 python package changes.

@GerhardOfRivia
Copy link
Contributor Author

Currently the pyproject file it doesn't change the container build behavior just the configuration of both black and ruff. The pipx update will be good time to improve the build process for the container and change to use poetry in the future.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@ryanmelt ryanmelt merged commit c18bbdb into OpenC3:main May 23, 2024
16 of 18 checks passed
@GerhardOfRivia GerhardOfRivia deleted the py-typing-model branch May 23, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants