Fix several python packet config options #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TEMPLATE, TEMPLATE_FILE are still needed. They provide the default buffer value, especially required for certain accessors. |
ryanmelt
requested changes
Apr 28, 2024
| @@ -438,37 +472,44 @@ def process_current_packet(self, parser, keyword, params): | |||
| klass = get_class_from_module( | |||
| f"openc3.accessors.{filename}", params[0] | |||
| ) | |||
| if params.length > 1: | |||
| # TODO: Dead code because accessors do not take parameters | |||
| # Remove or support future accessors with params? | |||
There was a problem hiding this comment.
Accessors can take parameters.
| usage = f"{keyword} <Template string>" | ||
| parser.verify_num_parameters(1, 1, usage) | ||
| self.current_packet.template = params[0] | ||
| # TODO: Not implemented |
| case "TEMPLATE_FILE": | ||
| usage = f"{keyword} <Template file path>" | ||
| parser.verify_num_parameters(1, 1, usage) | ||
| # case "TEMPLATE_FILE": |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Python GENERIC_READ_CONVERSION, GENERIC_WRITE_CONVERSION, HAZARDOUS without descriptions, SEG_POLY_READ_CONVERSION, SEG_POLY_WRITE_CONVERSION, MINIMUM_VALUE, MAXIMUM_VALUE, DEFAULT_VALUE.
Removed Python TEMPLATE, TEMPLATE_FILE (new Python code should use RESPONSE and ERROR_RESPONSE)