Skip to content

Recurring Calendar activities #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 1, 2024
Merged

Recurring Calendar activities #1171

merged 13 commits into from
May 1, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Apr 5, 2024

closes #3

@jmthomas jmthomas requested a review from ryanmelt April 5, 2024 04:02
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 76.05%. Comparing base (c9ca134) to head (527f4b6).
Report is 31 commits behind head on main.

❗ Current head 527f4b6 differs from pull request most recent head 934f431. Consider uploading reports for the commit 934f431 to get more accurate results

Files Patch % Lines
openc3/lib/openc3/script/plugins.rb 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   76.47%   76.05%   -0.42%     
==========================================
  Files         575      521      -54     
  Lines       42551    41228    -1323     
  Branches      759      758       -1     
==========================================
- Hits        32540    31357    -1183     
+ Misses       9928     9788     -140     
  Partials       83       83              
Flag Coverage Δ
frontend 55.34% <ø> (+<0.01%) ⬆️
python 83.02% <ø> (-0.15%) ⬇️
ruby-api 25.61% <ø> (-33.76%) ⬇️
ruby-backend 80.07% <82.35%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas changed the title Recurring events Recurring Calendar activities Apr 11, 2024
Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well overall. Whenever I try to edit a recurring item, I get a 500 error though. Should be able to edit individual items successfully.

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.3% Duplication on New Code

See analysis details on SonarCloud

@jmthomas jmthomas merged commit 1db16b8 into main May 1, 2024
17 checks passed
@jmthomas jmthomas deleted the recurring branch May 1, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recuring event in Calendar Timelines
2 participants