Skip to content

Implement DISABLED for commands #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Implement DISABLED for commands #1138

merged 4 commits into from
Mar 14, 2024

Conversation

jmthomas
Copy link
Member

This needs work because the error messages in Script Runner aren't correct yet.

close #1118

@jmthomas jmthomas requested a review from ryanmelt March 11, 2024 04:24
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 75.07%. Comparing base (a7dd92d) to head (2f20988).
Report is 6 commits behind head on main.

Files Patch % Lines
...openc3/microservices/trigger_group_microservice.rb 57.14% 3 Missing ⚠️
openc3/lib/openc3/logs/packet_log_reader.rb 80.00% 1 Missing ⚠️
openc3/lib/openc3/models/auth_model.rb 75.00% 1 Missing ⚠️
openc3/lib/openc3/system/system.rb 50.00% 1 Missing ⚠️
openc3/lib/openc3/utilities/authorization.rb 0.00% 1 Missing ⚠️
openc3/python/openc3/utilities/store.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
+ Coverage   75.01%   75.07%   +0.06%     
==========================================
  Files         594      594              
  Lines       43829    43875      +46     
  Branches      757      757              
==========================================
+ Hits        32879    32941      +62     
+ Misses      10867    10851      -16     
  Partials       83       83              
Flag Coverage Δ
frontend 55.60% <ø> (+0.14%) ⬆️
python 83.12% <96.55%> (+0.09%) ⬆️
ruby-api 48.70% <100.00%> (ø)
ruby-backend 80.08% <88.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmthomas jmthomas merged commit 0f6e17e into main Mar 14, 2024
@jmthomas jmthomas deleted the disabled branch March 14, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DISABLED commands aren't disabled
1 participant