Skip to content

Fix import of pandas, and use of PYPI_URL #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

ryanmelt
Copy link
Member

@ryanmelt ryanmelt commented Mar 1, 2024

closes #1098

@ryanmelt ryanmelt requested a review from jmthomas March 1, 2024 01:08
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.06%. Comparing base (a4da0da) to head (67e8f8f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   75.09%   75.06%   -0.04%     
==========================================
  Files         593      593              
  Lines       43627    43627              
  Branches      757      757              
==========================================
- Hits        32761    32747      -14     
- Misses      10783    10797      +14     
  Partials       83       83              
Flag Coverage Δ
frontend 55.43% <ø> (-0.13%) ⬇️
python 83.27% <ø> (-0.06%) ⬇️
ruby-api 48.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had the url wrong? What is the encoding for?

@ryanmelt
Copy link
Member Author

ryanmelt commented Mar 1, 2024

Using url wrong was breaking dependency installs. What you saw with requirements.txt last night.
Actual pandas fix was adding a encoding property. Our IoMultiplexor override of Stdout/Stderr was breaking pandas without that.

@ryanmelt ryanmelt merged commit a381e30 into main Mar 1, 2024
@ryanmelt ryanmelt deleted the python_fix_import_pandas branch March 1, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python unable to import pandas
2 participants