Skip to content

Add suite, group, script to report file name #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

jmthomas
Copy link
Member

closes #1102

@jmthomas jmthomas requested a review from ryanmelt February 19, 2024 18:53
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
2.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (574d816) 75.12% compared to head (8f38797) 75.09%.

Files Patch % Lines
...mos-script-runner-api/app/models/running_script.rb 9.52% 19 Missing ⚠️
openc3/lib/openc3/script/suite_results.rb 20.00% 4 Missing ⚠️
...enc3-cosmos-script-runner-api/app/models/script.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
- Coverage   75.12%   75.09%   -0.04%     
==========================================
  Files         593      593              
  Lines       43549    43574      +25     
  Branches      756      756              
==========================================
+ Hits        32716    32721       +5     
- Misses      10749    10769      +20     
  Partials       84       84              
Flag Coverage Δ
frontend 55.53% <100.00%> (-0.05%) ⬇️
python 83.31% <ø> (+0.05%) ⬆️
ruby-api 48.69% <9.09%> (-0.08%) ⬇️
ruby-backend 80.08% <20.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit 18e8bb6 into main Feb 25, 2024
@jmthomas jmthomas deleted the script_log_name branch February 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script Runner log file name incorporate suite, group, script name
2 participants