Skip to content

CmdTlmServer clear counters #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2024
Merged

CmdTlmServer clear counters #1089

merged 2 commits into from
Feb 9, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Feb 8, 2024

closes #357

@jmthomas jmthomas requested a review from ryanmelt February 8, 2024 21:35
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (fd35db7) 75.13% compared to head (3c1c254) 75.11%.

Files Patch % Lines
...dtlmserver/src/tools/CmdTlmServer/CmdTlmServer.vue 25.00% 6 Missing ⚠️
...lib/openc3/microservices/interface_microservice.rb 68.42% 6 Missing ⚠️
openc3/lib/openc3/interfaces/interface.rb 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   75.13%   75.11%   -0.03%     
==========================================
  Files         593      593              
  Lines       43495    43520      +25     
  Branches      754      754              
==========================================
+ Hits        32681    32690       +9     
- Misses      10734    10750      +16     
  Partials       80       80              
Flag Coverage Δ
frontend 55.51% <25.00%> (-0.14%) ⬇️
python 83.28% <100.00%> (-0.04%) ⬇️
ruby-api 48.76% <ø> (ø)
ruby-backend 80.09% <75.67%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jmthomas jmthomas merged commit f315a7a into main Feb 9, 2024
@jmthomas jmthomas deleted the clear_counters branch February 9, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any way to "Clear Counters" in CmdTlmServer like in COSMOS V4?
1 participant