Dynamic target packet definition creation support. #1048
Conversation
…se change. Update docusaurus
| # Attempt to remove all older versions of this same plugin before install to prevent version conflicts | ||
| # Especially on downgrades | ||
| # Leave the same version if it already exists | ||
| OpenC3::GemModel.destroy_all_other_versions(File.basename(gem_file_path)) |
There was a problem hiding this comment.
We leave the same version ... does the install process detect this and just abort the install?
There was a problem hiding this comment.
The same version just gets left for the install.
| @items = new_items | ||
| @sorted_items = new_sorted_items | ||
| clear_config_name() | ||
| end |
There was a problem hiding this comment.
Its called by the user. See my prometheus plugin soon.
| # TODO: Add TEMPLATE_ENCODED so this can always be done inline regardless of content | ||
| if @template | ||
| config << " TEMPLATE '#{@template}'" | ||
| end |
There was a problem hiding this comment.
I don't understand this TODO comment
There was a problem hiding this comment.
I'll write the corresponding ticket. In short we need a TEMPLATE keyword that takes base64 encoded data so a multiline string can be handled in one line of config file.
| bucket_key = File.join(bucket_path, file['name']) | ||
| local_path = "#{base_dir}/targets/#{target_name}/cmd_tlm/#{file['name']}" | ||
| bucket.get_object(bucket: ENV['OPENC3_CONFIG_BUCKET'], key: bucket_key, path: local_path) | ||
| end |
There was a problem hiding this comment.
This block is pulling down the dynamically created packets back into the local target_modified directory?
There was a problem hiding this comment.
It is pulling them down into the files used to create the System object yes.
| ) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Called by user. See prometheus metrics plugin.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
- Coverage 75.35% 75.31% -0.05%
==========================================
Files 592 592
Lines 43197 43277 +80
Branches 746 746
==========================================
+ Hits 32553 32592 +39
- Misses 10565 10606 +41
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
Is there documentation or an example somewhere of how to implement dynamic telemetry packets? |
Also
Improve build time to only rebuild docs tools on base change
Update docusaurus
closes #419
closes #1026
closes #1044