Skip to content

Fix bucket explorer route #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Fix bucket explorer route #1047

merged 1 commit into from
Jan 13, 2024

Conversation

jmthomas
Copy link
Member

closes #1042

@jmthomas jmthomas requested a review from ryanmelt January 12, 2024 19:33
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c313ed1) 75.34% compared to head (0ee5789) 75.33%.

Files Patch % Lines
...-cmd-tlm-api/app/controllers/storage_controller.rb 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   75.34%   75.33%   -0.01%     
==========================================
  Files         590      590              
  Lines       43135    43136       +1     
  Branches      749      749              
==========================================
- Hits        32498    32497       -1     
- Misses      10559    10561       +2     
  Partials       78       78              
Flag Coverage Δ
frontend 55.25% <ø> (-0.06%) ⬇️
python 83.63% <ø> (+<0.01%) ⬆️
ruby-api 48.71% <66.66%> (+0.01%) ⬆️
ruby-backend 80.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit cdf253f into main Jan 13, 2024
@jmthomas jmthomas deleted the bucket_files branch January 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bucket Explorer not showing files in gem volume mount folders
2 participants