Add queued store and display active users #1045
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
==========================================
+ Coverage 75.32% 75.36% +0.03%
==========================================
Files 590 592 +2
Lines 43138 43197 +59
Branches 746 746
==========================================
+ Hits 32493 32554 +61
+ Misses 10566 10564 -2
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| module OpenC3 | ||
| class StoreQueued | ||
| # How often in seconds the store is updated | ||
| UPDATE_INTERVAL = 2 |
There was a problem hiding this comment.
This needs to be an argument to the instance on first use (like System). I want to use this same class to implement #987
| # Mutex used to ensure that only one instance is created | ||
| @@instance_mutex = Mutex.new | ||
|
|
||
| # Thread used to post metrics across all classes |
| end | ||
| end | ||
|
|
||
| def self.shutdown |
There was a problem hiding this comment.
no one ... it's left over from the metrics thread I borrowed
There was a problem hiding this comment.
Should be added to at_exit when instance created
| @store_queue = Queue.new | ||
|
|
||
| at_exit() do | ||
| self.shutdown() |
There was a problem hiding this comment.
Make shutdown an instance method
| @@instance_mutex = Mutex.new | ||
|
|
||
| # Thread used to call methods on the store | ||
| @@update_thread = nil |
There was a problem hiding this comment.
This should just be an instance variable
| @@update_thread = nil | ||
|
|
||
| # Sleeper used to delay update thread | ||
| @@update_sleeper = nil |
There was a problem hiding this comment.
This should just be an instance variable
| end | ||
| end | ||
|
|
||
| def self.shutdown |
|
Let me make some changes to this one before you merge it. |
|
No description provided.