Only run processors in decom microservice #1019
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
+ Coverage 75.28% 75.31% +0.02%
==========================================
Files 588 588
Lines 42990 42990
Branches 749 749
==========================================
+ Hits 32367 32376 +9
+ Misses 10545 10536 -9
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
| @@ -100,6 +100,7 @@ def decom_packet(topic, msg_id, msg_hash, _redis) | |||
| packet.extra = extra | |||
| end | |||
| packet.buffer = msg_hash["buffer"] | |||
| packet.process # Run processors | |||
There was a problem hiding this comment.
So previously they were run on any buffer assignment but not it's only run explicitly. Did processors previously run multiple times in the packet processing chain? What are the side effects of this change?
There was a problem hiding this comment.
In COSMOS 5, they were being run in both the Interface and the Decom microservices before this change.
Now they will only run once in Decom.
Side effects are if you needed them in the Interface/Protocol for some reason you will need to run them manuallly or add a "runProcessors" Protocol or something.
Now processors can be used for things like sending commands, without having them run twice.
closes #838