Converter injection

[MacDada]

I want to strip <style> tags: $converter->setStripOriginalStyleTags(true);

How about an optional constructor injection to give a possibility to use custom options?

/**
 * @param CssToInlineStyles $converter
 */
public function __construct(CssToInlineStyles $converter = null)
{
    if ($converter) {
        $this->converter = $converter;
    } else {
        $this->converter = new CssToInlineStyles();
        $this->converter->setUseInlineStylesBlock(TRUE);
    }
}

[hkdobrev]

👍

This would be very nice! It would allow configuring every option via the original setters.

[ivank]

👍
Thats a great idea actually.

[MacDada]

How about getting rid of $this->converter->setUseInlineStylesBlock(TRUE);? The constructor could be even simpler, although it would be a backward compatibility break:

$this->converter = $converter ?: new CssToInlineStyles();