Which case should we use for FONT grade?

[actuallyyun]

Currently, the Font grade uses lowercase, and does not support uppercase:

Font.getScore('7B') Output: 0

Font.getScore('7b') Output: [ 76, 77 ]

I think it would be a good idea to use uppercase for the FONT grade to distinguish it from the French sports grade, but supports lowercase input as well.

What do you think? @musoke

[musoke]

Yes, I would consider this a bug. If anything it should be the opposite

…

On Fri, Apr 28, 2023, 04:46 Yun Ji ***@***.***> wrote: Currently, the Font grade uses lowercase, and does not support uppercase: Font.getScore('7B') Output: 0 Font.getScore('7b') Output: [ 76, 77 ] I think it would be a good idea to use uppercase for the FONT grade to distinguish it from the French sports grade, but supports lowercase input as well. What do you think? @musoke <https://github.com/musoke> — Reply to this email directly, view it on GitHub <#107>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD7ET7DGVXJKH5DZKOMS3CTXDN7VZANCNFSM6AAAAAAXO55DGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[musoke]

Allowing uppercase would be easy.

Need to check how they're stored in https://github.com/openbeta/openbeta-graphql and double check with a lot of people before disallowing lowercase - I suspect that disallowing lowercase will break routes currently in the db.

[actuallyyun]

I see. Also later I noticed inconsistencies in allowing lower/upper cases in font scale methods. (isType is not case sensitive)
To begin with, should I delete this from README since this behavior is not consistent

// Font grade is not case sensitive
console.log('Is 6a a Font Scale?',Font.isType('6a'))

Then we could begin a discussion about which case to allow for font grade.
What do you think?

[musoke]

I agree, remove that from the examples.