Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Loading text doesn't go away when searching for mods by peerId #1862

@rmisio

Description

@rmisio

This was tested against the refactorModLoading branch.

Steps to reproduce:

  • In Settings > Store, search for a mod by peerId
  • When the mod loads, click Find to search for the same mod.

Observed:
Loading moderator 1 of 1 is shown and never goes away.

image

Expectations:

  • Perhaps Loading moderator 1 of 1 shows briefly or not at all, but it doesn't stay perpetually.

Similar issue:

Steps to reproduce:

  • In Settings > Store, search for a valid Mod by peerId and wait until the mod loads.
  • Search for a non-existent peer by peerId (the peerId should be a valid multihash, just not map to a reachable OB node)

Observed:
An error message is shown indicating the node was not reached and Loading moderator 1 of 1 is shown and never goes away.

image

Expectations:

  • Loading moderator 1 of 1 disappears after it's determined the peerId was not found and the error message is shown.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions