Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payments Requests containing ReadRefundAccount=Yes should return accountNo and sortcode #14

Closed
2 tasks done
BohoCode opened this issue Dec 7, 2020 · 2 comments · Fixed by OpenBankingToolkit/openbanking-aspsp#319, OpenBankingToolkit/openbanking-uk-extensions#104 or OpenBankingToolkit/openbanking-reference-implementation#352
Closed
2 tasks done

Payments Requests containing ReadRefundAccount=Yes should return accountNo and sortcode #14

BohoCode opened this issue Dec 7, 2020 · 2 comments · Fixed by OpenBankingToolkit/openbanking-aspsp#319, OpenBankingToolkit/openbanking-uk-extensions#104 or OpenBankingToolkit/openbanking-reference-implementation#352
Assignees
@jsanhc
Labels
enhancement New feature or request fixed: t-rex
Milestone
t-rex

Comments

@BohoCode
Copy link
Contributor

BohoCode commented Dec 7, 2020 •
edited by jsanhc
Loading

ZD: 55834

When a TPP sets the ReadRefundAccount=yes in a payment request the response should contain Sort Code and Account Number.

The ReadRefundAccount field was added in 3.1.4 so this functionality needs to be put into a filter and that filter needs to be added to 3.1.4, 3.1.5 & 3.1.6 controllers.

Acceptance Criteria

  • End to end test in postman covers this functionality and pass against master
  • Functional Tests cover this functionality and pass against master
@BohoCode BohoCode added the enhancement New feature or request label Dec 7, 2020
@BohoCode BohoCode added this to the t-rex milestone Dec 15, 2020
@BohoCode BohoCode mentioned this issue Dec 21, 2020
Merged
@jsanhc
Copy link
Contributor

jsanhc commented Dec 23, 2020 •
edited
Loading

Payments affected

  • DomesticPayment
  • DomesticScheduledPayment
  • DomesticStandingOrder
  • InternationalPayment
  • InternationalScheduledPayment
  • InternationalStandingOrder

Versions

  • From 3.1.4 to latest

@jsanhc
Copy link
Contributor

jsanhc commented Dec 23, 2020 •
edited
Loading

Related issue: 16:Payment Initiation model version 3.1.4 missed fields (Refund)

  • Fixed

jsanhc added a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Dec 24, 2020
@jsanhc
14: payments refunds
d25af09 
- Domestic payments
- Internationsl payments
Issue: OpenBankingToolkit/openbanking-toolkit#14
jsanhc added a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Jan 5, 2021
@jsanhc
14: payments refunds
7e0de82 
- Domestic payments
- Internationsl payments
Issue: OpenBankingToolkit/openbanking-toolkit#14
jsanhc added a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Jan 11, 2021
@jsanhc
14: payment refunds - Domestic payments (#314)
7990cc3 
* 14: payment refunds - Domestic payments
- Generated API version 3.1.4 and delete extended version 3.1.3
  - modules: aspsp-rs-gateway, aspsp-rs-mock-store
- Create converter for version 3.1.4
- Fix converter 3.1.5 to handler `Read refund account` enumeration values in consent
- Introduced in the payment response the `refund` object account when `read refund account` is set to `YES`
- Created Integration tests for versions 3.1.4 and 3.1.6(extends 3.1.5)
- Domestic payments
- International payments
Issue: OpenBankingToolkit/openbanking-toolkit#14
* Update starter parent to the latest version
* suggested changes and improvements
* fix packagePayment method name to responseEntity on all versions, delete final modifier on RefundPaymentsFactory
@jsanhc jsanhc mentioned this issue Jan 11, 2021
Merged
@jsanhc jsanhc mentioned this issue Jan 11, 2021
Merged
@BohoCode BohoCode reopened this Jan 12, 2021
@BohoCode BohoCode changed the title Payments Requestions containing ReadRefundAccount=Yes should return accountNo and sortcode Payments Requests containing ReadRefundAccount=Yes should return accountNo and sortcode Jan 12, 2021
@jsanhc jsanhc mentioned this issue Jan 13, 2021
Merged
@jsanhc jsanhc mentioned this issue Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsanhc jsanhc

Labels
enhancement New feature or request fixed: t-rex
Projects
None yet
Milestone
t-rex
2 participants
@BohoCode @jsanhc