-
Notifications
You must be signed in to change notification settings - Fork 459
RabbitMQ; resource_docs_requires_role #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
simonredfern
merged 17 commits into
OpenBankProject:develop
from
constantine2nd:develop
Feb 10, 2026
Merged
RabbitMQ; resource_docs_requires_role #2671
simonredfern
merged 17 commits into
OpenBankProject:develop
from
constantine2nd:develop
Feb 10, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 77b10d7.
This reverts commit c907e17.
… memory spikes" This reverts commit e6009fa.
Summary of Changes 1. ApiRole.scala - 7 new bank-scoped roles added: - CanUseCustomerFirehose (after CanUseCustomerFirehoseAtAnyBank) - CanGetTransactionRequestAtOneBank (after CanGetTransactionRequestAtAnyBank) - CanUpdateTransactionRequestStatusAtOneBank (after CanUpdateTransactionRequestStatusAtAnyBank) - CanGetEntitlementRequestsAtOneBank (after CanGetEntitlementRequestsAtAnyBank) - CanDeleteEntitlementRequestsAtOneBank (after CanDeleteEntitlementRequestsAtAnyBank) - CanDeleteScopeAtOneBank (after CanDeleteScopeAtAnyBank) - CanGetAccountsMinimalForCustomerAtOneBank (after CanGetAccountsMinimalForCustomerAtAnyBank) 2. APIMethods510.scala - 2 security fixes: - GET /management/transaction-requests/TRANSACTION_REQUEST_ID: Added authenticatedAccess and entitlement check using transactionRequest.from.bank_id - PUT /management/transaction-requests/TRANSACTION_REQUEST_ID: Added authenticatedAccess and entitlement check using existingTransactionRequest.from.bank_id 3. APIMethods600.scala - 1 auth fix: - GET /management/roles-with-entitlement-counts: Added hasEntitlement check for canGetRolesWithEntitlementCountsAtAllBanks 4. APIMethods400.scala - 1 security fix: - GET /customers/CUSTOMER_ID/accounts-minimal: Added authenticatedAccess and entitlement check using customer.bankId 5. APIMethods310.scala - 1 endpoint update: - GET /banks/BANK_ID/firehose/customers: Updated to accept both canUseCustomerFirehose (bank-scoped) and canUseCustomerFirehoseAtAnyBank (system-scoped) via hasAtLeastOneEntitlement 6. APIMethods300.scala - 3 endpoint updates: - GET /entitlement-requests: ResourceDoc updated with both roles - GET /users/USER_ID/entitlement-requests: ResourceDoc updated with both roles - DELETE /entitlement-requests/ENTITLEMENT_REQUEST_ID: Fetches the entitlement request first to get bankId, then checks both bank-scoped and system-scoped roles - DELETE /consumers/CONSUMER_ID/scope/SCOPE_ID: Added canDeleteScopeAtOneBank / canDeleteScopeAtAnyBank roles to ResourceDoc, fetches scope first to get bankId, tries bank-scoped then falls back to system-scoped via hasEntitlementAndScope
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



No description provided.