Skip to content

Conversation

@constantine2nd
Copy link
Contributor

No description provided.

@constantine2nd constantine2nd changed the title RabbitMQ RabbitMQ; resource_docs_requires_role Feb 3, 2026
Summary of Changes

1. ApiRole.scala - 7 new bank-scoped roles added:

- CanUseCustomerFirehose (after CanUseCustomerFirehoseAtAnyBank)
- CanGetTransactionRequestAtOneBank (after CanGetTransactionRequestAtAnyBank)
- CanUpdateTransactionRequestStatusAtOneBank (after CanUpdateTransactionRequestStatusAtAnyBank)
- CanGetEntitlementRequestsAtOneBank (after CanGetEntitlementRequestsAtAnyBank)
- CanDeleteEntitlementRequestsAtOneBank (after CanDeleteEntitlementRequestsAtAnyBank)
- CanDeleteScopeAtOneBank (after CanDeleteScopeAtAnyBank)
- CanGetAccountsMinimalForCustomerAtOneBank (after CanGetAccountsMinimalForCustomerAtAnyBank)

2. APIMethods510.scala - 2 security fixes:

- GET /management/transaction-requests/TRANSACTION_REQUEST_ID:
  Added authenticatedAccess and entitlement check using transactionRequest.from.bank_id
- PUT /management/transaction-requests/TRANSACTION_REQUEST_ID:
  Added authenticatedAccess and entitlement check using existingTransactionRequest.from.bank_id

3. APIMethods600.scala - 1 auth fix:

- GET /management/roles-with-entitlement-counts:
  Added hasEntitlement check for canGetRolesWithEntitlementCountsAtAllBanks

4. APIMethods400.scala - 1 security fix:

- GET /customers/CUSTOMER_ID/accounts-minimal:
  Added authenticatedAccess and entitlement check using customer.bankId

5. APIMethods310.scala - 1 endpoint update:

- GET /banks/BANK_ID/firehose/customers:
  Updated to accept both canUseCustomerFirehose (bank-scoped) and
  canUseCustomerFirehoseAtAnyBank (system-scoped) via hasAtLeastOneEntitlement

6. APIMethods300.scala - 3 endpoint updates:

- GET /entitlement-requests:
  ResourceDoc updated with both roles
- GET /users/USER_ID/entitlement-requests:
  ResourceDoc updated with both roles
- DELETE /entitlement-requests/ENTITLEMENT_REQUEST_ID:
  Fetches the entitlement request first to get bankId, then checks both
  bank-scoped and system-scoped roles
- DELETE /consumers/CONSUMER_ID/scope/SCOPE_ID:
  Added canDeleteScopeAtOneBank / canDeleteScopeAtAnyBank roles to ResourceDoc,
  fetches scope first to get bankId, tries bank-scoped then falls back to
  system-scoped via hasEntitlementAndScope
@sonarqubecloud
Copy link

@simonredfern simonredfern merged commit 5bd6f9b into OpenBankProject:develop Feb 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants