Use absolute paths to load libraries #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What does this method return for all OSes? |
Contributor
|
I think unpack_from_jar method should return full path and it should be used by jna loadlibrary And seems like I need to do the same in brainflow |
philippitts
force-pushed
the
use-absolute-library-paths
branch
from
1c28672 to
10f81dc
Compare
Andrey1994
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add entitlements to MacOS applications and get it notarized by Apple, the program has to meet hardened runtime requirements. Using entitlements is required to allow embedded plugins to access different permissions on MacOS. The hardened runtime requirements disallow using relative paths for dynamic libraries to prevent dynamic library hijacking. This PR updates the library loading implementation to use absolute paths.