Skip to content

[backend] Using parallel stream to execute injects #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented May 7, 2025

Proposed changes

  • Changing the job of inject execution to make use of parallelism

Testing Instructions

  1. Create a simulation with a lot of injects launching at the same time
  2. Launch it
  3. It should start them all at the same time

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 41.41%. Comparing base (5c0a870) to head (bc995a0).
Report is 3 commits behind head on release/current.

Files with missing lines Patch % Lines
...io/openbas/scheduler/jobs/InjectsExecutionJob.java 14.28% 12 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/current    #3129   +/-   ##
==================================================
  Coverage              41.40%   41.41%           
  Complexity              2346     2346           
==================================================
  Files                    693      693           
  Lines                  21292    21294    +2     
  Branches                1453     1453           
==================================================
+ Hits                    8817     8818    +1     
- Misses                 11978    11979    +1     
  Partials                 497      497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dimfacion Dimfacion merged commit 472ed90 into release/current May 9, 2025
8 checks passed
@Dimfacion Dimfacion deleted the improvment/parallel-inject-execution branch May 9, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants