Skip to content

refactor: migrate plugin-import to plugin-import-x #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JounQin
Copy link

@JounQin JounQin commented Apr 13, 2025

Proposed changes

also replace import-resolver-oxc to the new import-resolver-typescript

Related issues

N/A

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

https://github.com/un-ts/eslint-plugin-import-x

Just quote from other PRs:

{
settings: {
'import/resolver': 'oxc',
'import/ignore': [
'import-x/resolver-next': [createTypeScriptImportResolver()],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better performance

@savacano28 savacano28 added the community use to identify PR from community label Apr 17, 2025
@RomuDeuxfois
Copy link
Member

Hi @JounQin ,

Thanks a lot for your PR and for taking the time to integrate your library into our project.
But, for the sake of consistency and maintainability, we prefer to stick with the current library, which is already well-established in our codebase and widely adopted in the community.

Thanks again

@JounQin
Copy link
Author

JounQin commented Apr 22, 2025

@RomuDeuxfois That's totally fine, this is just a proposal and showing case how much the lint flow could be improved.

By at least the oxc resolver should be replaced by typescript because it understands TypeScript better.

@JounQin JounQin force-pushed the refactor/import-resolver branch 3 times, most recently from 366c508 to 9a336fe Compare April 22, 2025 14:57
also `import-resolver-oxc` to the new `import-resolver-typescript`
@JounQin JounQin force-pushed the refactor/import-resolver branch from 9a336fe to c7b293d Compare May 5, 2025 10:32
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.09%. Comparing base (92441bc) to head (c7b293d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2939   +/-   ##
=========================================
  Coverage     41.09%   41.09%           
  Complexity     2330     2330           
=========================================
  Files           691      691           
  Lines         21226    21226           
  Branches       1446     1446           
=========================================
  Hits           8723     8723           
  Misses        12010    12010           
  Partials        493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants