-
Notifications
You must be signed in to change notification settings - Fork 115
refactor: migrate plugin-import
to plugin-import-x
#2939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
{ | ||
settings: { | ||
'import/resolver': 'oxc', | ||
'import/ignore': [ | ||
'import-x/resolver-next': [createTypeScriptImportResolver()], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even better performance
Hi @JounQin , Thanks a lot for your PR and for taking the time to integrate your library into our project. Thanks again |
@RomuDeuxfois That's totally fine, this is just a proposal and showing case how much the lint flow could be improved. By at least the |
366c508
to
9a336fe
Compare
also `import-resolver-oxc` to the new `import-resolver-typescript`
9a336fe
to
c7b293d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2939 +/- ##
=========================================
Coverage 41.09% 41.09%
Complexity 2330 2330
=========================================
Files 691 691
Lines 21226 21226
Branches 1446 1446
=========================================
Hits 8723 8723
Misses 12010 12010
Partials 493 493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Proposed changes
also replace
import-resolver-oxc
to the newimport-resolver-typescript
Related issues
N/A
Checklist
Further comments
https://github.com/un-ts/eslint-plugin-import-x
Just quote from other PRs:
import-x
with lighter deps and better performance shlinkio/js-coding-standard#129 (comment)resolver-oxc
with newresolver-typescript
SocketDev/socket-cli#386 (comment)