feat: add tcl test 2 #2497
Merged
feat: add tcl test 2 #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 4, 2024 17:21
github-actions
bot
added
☢️ Bug
luky116
reviewed
Mar 12, 2024
| test {AUTH succeeds when the right password is given} { | ||
| r auth foobar | ||
| } {OK} | ||
| # test {AUTH fails when a wrong password is given} { |
AlexStocks
approved these changes
Mar 12, 2024
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
* add tcl test * Update default.conf --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
luky116
pushed a commit
to luky116/pika
that referenced
this pull request
Mar 14, 2024
* add tcl test * Update default.conf --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
luky116
pushed a commit
that referenced
this pull request
Mar 18, 2024
* add tcl test * Update default.conf --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* add tcl test * Update default.conf --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* add tcl test * Update default.conf --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* add tcl test * Update default.conf --------- Co-authored-by: wuxianrong <wuxianrong@360.cn> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2046
在这个
PR中，我们新加了之前注释掉的basic,scan,expire,multi,quit,list,pubsub,slowlog,protocol,maxmemory,bitops,hyperloglog的 TCL 测试，将Redis的TCL单测在Pika上几乎全部进行了覆盖，至于剩下的一部分单测类型没有解掉注释的原因在于这些类型中部分命令Pika暂不支持，例如Rename,Debug,Move,Save,Sort,Eval,Dump,Command等命令In this PR, We let go of the previous comments on basic, scan, expire, multi, quit, list, pubsub, slowlog, protocol, maxmemory, bitops, The TCL test of hyperloglog covers almost all the TCL single test of Redis on Pika. As for the remaining part of the single test types, the reason why the comments are not removed is that some commands of these types are not supported by Pika. For example, Rename, Debug, Move, Save, Sort, Eval, Dump, command, and so on