-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add unit test to github action #1604
Merged
AlexStocks
merged 7 commits into
OpenAtomFoundation:unstable
from
machinly:pika-unit-test
Jun 11, 2023
Merged
ci: add unit test to github action #1604
AlexStocks
merged 7 commits into
OpenAtomFoundation:unstable
from
machinly:pika-unit-test
Jun 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Jun 9, 2023
chenbt-hz
reviewed
Jun 10, 2023
chenbt-hz
reviewed
Jun 10, 2023
exit 1 | ||
fi | ||
cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code review of this patch is as follows:
- A cleanup function is added to remove log, db and dbsync directories
- Functions are defined to check if tcl is installed, setup build directory, and pika binary and configuration file
- The removal of the "rm -rf ./db" command from the original script may potentially leave residual database files in the current directory and the new cleanup function does not remove these either.
- Code seems to lack proper error handling mechanisms, i.e., it just exits with an error message but does not specify what caused the error or how to fix it.
- It might be useful to add a logging mechanism to stream output to a separate file and ensure that users can review test results more easily.
Some possible improvements to the existing code may include:
- Adding proper error handling to the code, such as specifying error types and potential solutions.
- Instead of using multiple functions, it would be better to use a single function broken down into logical blocks for readability and simplicity.
- Checking the permissions before removing files or directories to avoid accidental deletion of critical files that can cause issues later on.
- Clearing the necessary directories more effectively by using more specialized commands like
find
instead ofrm -rf
.
先合入,后面再优化,先有个架子 |
wanghenshui
approved these changes
Jun 11, 2023
我没有合入权限,@AlexStocks 合一下 |
chenbt-hz
approved these changes
Jun 11, 2023
AlexStocks
approved these changes
Jun 11, 2023
lqxhub
pushed a commit
to lqxhub/pika
that referenced
this pull request
Jun 18, 2023
* ci: add unit test in github workflow
AlexStocks
added a commit
that referenced
this pull request
Jul 2, 2023
* feat: supported 'ptype' command * Simplified command `type` and `ptype` code * Remove the capacity judgment * fix slavaof serialize response bug (#1583) Co-authored-by: liuyuecai <liuyuecai@360.cn> * fix (#1587) (#1588) * fix unit test:type/set (#1577) * Fix memory leaks in HandleBGWorkerWriteDB and HandleMetaSyncResponse (#1590) * fix memory leaks in PikaReplBgWorker::HandleBGWorkerWriteDB(void* arg) and PikaReplClientConn::HandleMetaSyncResponse(void* arg). * add address/thread sanitizer to CMakeLists --------- Co-authored-by: cjh <1271435567@qq.com> * refactor: replace pstd/env with std::filesystem (#1470) * fix bug issue 1554: using unique_ptr.reset to fix the SIGABRT error (#1595) using unique_ptr.reset to fix the SIGABRT error && using time-wait lock to notify quickly * fix: incorrect manner of terminating the process (#1596) * fix issue#1597: add rocksdb dependency to pstd (#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix_info_command * fix: gcc13 compile failed (#1601) * ci: add unit test to github action (#1604) * ci: add unit test in github workflow * chore:change `PLATFORM` field logic (#1615) * fix issue 1517: scan 命令不支持 type 参数 (#1582) * fix: the unit test of type/set (#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * [fix issue1621] fix deadlock (#1620) * [fix] fix deadlock * [fix] fix * command `type` and `ptype` add unit test * fix member variable initialization * Update issue templates * feat: supported 'ptype' command * fix unit test:type/set (#1577) * fix issue#1597: add rocksdb dependency to pstd (#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix: gcc13 compile failed (#1601) * fix: the unit test of type/set (#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * Modify other modules to use the new `type` function * fix function repeat --------- Co-authored-by: Yuecai Liu <38887641+luky116@users.noreply.github.com> Co-authored-by: liuyuecai <liuyuecai@360.cn> Co-authored-by: Peter Chan <luckygoose@foxmail.com> Co-authored-by: chenbt <34958405+chenbt-hz@users.noreply.github.com> Co-authored-by: Junhua Chen <41671101+cheniujh@users.noreply.github.com> Co-authored-by: cjh <1271435567@qq.com> Co-authored-by: kang jinci <jincikang@gmail.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: machinly <machinlyg@gmail.com> Co-authored-by: A2ureStone <73770413+A2ureStone@users.noreply.github.com> Co-authored-by: J1senn <J1senn@outlook.com> Co-authored-by: chejinge <945997690@qq.com> Co-authored-by: baerwang <52104949+baerwang@users.noreply.github.com> Co-authored-by: ptbxzrt <89020404+ptbxzrt@users.noreply.github.com> Co-authored-by: 你不要过来啊 <73388438+iiiuwioajdks@users.noreply.github.com>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* ci: add unit test in github workflow
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* feat: supported 'ptype' command * Simplified command `type` and `ptype` code * Remove the capacity judgment * fix slavaof serialize response bug (OpenAtomFoundation#1583) Co-authored-by: liuyuecai <liuyuecai@360.cn> * fix (OpenAtomFoundation#1587) (OpenAtomFoundation#1588) * fix unit test:type/set (OpenAtomFoundation#1577) * Fix memory leaks in HandleBGWorkerWriteDB and HandleMetaSyncResponse (OpenAtomFoundation#1590) * fix memory leaks in PikaReplBgWorker::HandleBGWorkerWriteDB(void* arg) and PikaReplClientConn::HandleMetaSyncResponse(void* arg). * add address/thread sanitizer to CMakeLists --------- Co-authored-by: cjh <1271435567@qq.com> * refactor: replace pstd/env with std::filesystem (OpenAtomFoundation#1470) * fix bug issue 1554: using unique_ptr.reset to fix the SIGABRT error (OpenAtomFoundation#1595) using unique_ptr.reset to fix the SIGABRT error && using time-wait lock to notify quickly * fix: incorrect manner of terminating the process (OpenAtomFoundation#1596) * fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix_info_command * fix: gcc13 compile failed (OpenAtomFoundation#1601) * ci: add unit test to github action (OpenAtomFoundation#1604) * ci: add unit test in github workflow * chore:change `PLATFORM` field logic (OpenAtomFoundation#1615) * fix issue 1517: scan 命令不支持 type 参数 (OpenAtomFoundation#1582) * fix: the unit test of type/set (OpenAtomFoundation#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * [fix issue1621] fix deadlock (OpenAtomFoundation#1620) * [fix] fix deadlock * [fix] fix * command `type` and `ptype` add unit test * fix member variable initialization * Update issue templates * feat: supported 'ptype' command * fix unit test:type/set (OpenAtomFoundation#1577) * fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix: gcc13 compile failed (OpenAtomFoundation#1601) * fix: the unit test of type/set (OpenAtomFoundation#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * Modify other modules to use the new `type` function * fix function repeat --------- Co-authored-by: Yuecai Liu <38887641+luky116@users.noreply.github.com> Co-authored-by: liuyuecai <liuyuecai@360.cn> Co-authored-by: Peter Chan <luckygoose@foxmail.com> Co-authored-by: chenbt <34958405+chenbt-hz@users.noreply.github.com> Co-authored-by: Junhua Chen <41671101+cheniujh@users.noreply.github.com> Co-authored-by: cjh <1271435567@qq.com> Co-authored-by: kang jinci <jincikang@gmail.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: machinly <machinlyg@gmail.com> Co-authored-by: A2ureStone <73770413+A2ureStone@users.noreply.github.com> Co-authored-by: J1senn <J1senn@outlook.com> Co-authored-by: chejinge <945997690@qq.com> Co-authored-by: baerwang <52104949+baerwang@users.noreply.github.com> Co-authored-by: ptbxzrt <89020404+ptbxzrt@users.noreply.github.com> Co-authored-by: 你不要过来啊 <73388438+iiiuwioajdks@users.noreply.github.com>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* ci: add unit test in github workflow
cheniujh
added a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* feat: supported 'ptype' command * Simplified command `type` and `ptype` code * Remove the capacity judgment * fix slavaof serialize response bug (OpenAtomFoundation#1583) Co-authored-by: liuyuecai <liuyuecai@360.cn> * fix (OpenAtomFoundation#1587) (OpenAtomFoundation#1588) * fix unit test:type/set (OpenAtomFoundation#1577) * Fix memory leaks in HandleBGWorkerWriteDB and HandleMetaSyncResponse (OpenAtomFoundation#1590) * fix memory leaks in PikaReplBgWorker::HandleBGWorkerWriteDB(void* arg) and PikaReplClientConn::HandleMetaSyncResponse(void* arg). * add address/thread sanitizer to CMakeLists --------- Co-authored-by: cjh <1271435567@qq.com> * refactor: replace pstd/env with std::filesystem (OpenAtomFoundation#1470) * fix bug issue 1554: using unique_ptr.reset to fix the SIGABRT error (OpenAtomFoundation#1595) using unique_ptr.reset to fix the SIGABRT error && using time-wait lock to notify quickly * fix: incorrect manner of terminating the process (OpenAtomFoundation#1596) * fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix_info_command * fix: gcc13 compile failed (OpenAtomFoundation#1601) * ci: add unit test to github action (OpenAtomFoundation#1604) * ci: add unit test in github workflow * chore:change `PLATFORM` field logic (OpenAtomFoundation#1615) * fix issue 1517: scan 命令不支持 type 参数 (OpenAtomFoundation#1582) * fix: the unit test of type/set (OpenAtomFoundation#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * [fix issue1621] fix deadlock (OpenAtomFoundation#1620) * [fix] fix deadlock * [fix] fix * command `type` and `ptype` add unit test * fix member variable initialization * Update issue templates * feat: supported 'ptype' command * fix unit test:type/set (OpenAtomFoundation#1577) * fix issue#1597: add rocksdb dependency to pstd (OpenAtomFoundation#1599) * fix g++15 compile failure * add rocksdb dependency to pstd --------- Co-authored-by: J1senn <J1senn@outlook.com> * fix: gcc13 compile failed (OpenAtomFoundation#1601) * fix: the unit test of type/set (OpenAtomFoundation#1617) * test: optimize the return results of srandmember to avoid approximate results * fix: use last_seed for random engine * Modify other modules to use the new `type` function * fix function repeat --------- Co-authored-by: Yuecai Liu <38887641+luky116@users.noreply.github.com> Co-authored-by: liuyuecai <liuyuecai@360.cn> Co-authored-by: Peter Chan <luckygoose@foxmail.com> Co-authored-by: chenbt <34958405+chenbt-hz@users.noreply.github.com> Co-authored-by: Junhua Chen <41671101+cheniujh@users.noreply.github.com> Co-authored-by: cjh <1271435567@qq.com> Co-authored-by: kang jinci <jincikang@gmail.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: machinly <machinlyg@gmail.com> Co-authored-by: A2ureStone <73770413+A2ureStone@users.noreply.github.com> Co-authored-by: J1senn <J1senn@outlook.com> Co-authored-by: chejinge <945997690@qq.com> Co-authored-by: baerwang <52104949+baerwang@users.noreply.github.com> Co-authored-by: ptbxzrt <89020404+ptbxzrt@users.noreply.github.com> Co-authored-by: 你不要过来啊 <73388438+iiiuwioajdks@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to Github Action, and comment out some test files that can't pass.