Skip to content

Comments

Remove interactive input device requirements from specifications#30

Merged
andre-stefanov merged 2 commits intomainfrom
copilot/fix-28
Aug 3, 2025
Merged

Remove interactive input device requirements from specifications#30
andre-stefanov merged 2 commits intomainfrom
copilot/fix-28

Conversation

Copy link
Contributor

Copilot AI commented Aug 3, 2025

This PR removes all requirements related to interactive input devices (buttons, joysticks, rotary encoders, touchscreens) from the firmware specifications, aligning with the architectural decision to focus on display-only output and protocol-based control.

Changes Made

Requirements Specification (specs/requirements.md)

  • Updated Section 11 title from "USER INTERFACE REQUIREMENTS" to "DISPLAY REQUIREMENTS"
  • Removed Section 11.2 "Input Device Requirements" entirely:
    • REQ-UI-004: Button input device support
    • REQ-UI-005: Joystick input device support
    • REQ-UI-006: Rotary encoder with button input device support
    • REQ-UI-007: Touch screen input device support
  • Removed Section 11.3 "Interactive Operations Requirements" entirely:
    • REQ-UI-008: Manual axis movement via input devices
    • REQ-UI-009: Starting/stopping tracking via input devices
    • REQ-UI-010: Finding home position via input devices
    • REQ-UI-011: Going to home position via input devices
    • REQ-UI-012: Entering target coordinates via input devices

Development Roadmap (ROADMAP.md)

  • Updated EPIC 7 title from "User Interface & Web Systems" to "Display & Web Systems"
  • Updated EPIC 7.1 from "Display & Input Device Support" to "Display Support"
  • Removed all interactive input device requirements from acceptance criteria
  • Updated requirements list to only include REQ-UI-001 through REQ-UI-003

Design Documentation (specs/design.md)

  • Updated cross-references to reflect only the preserved display requirements (REQ-UI-001 to REQ-UI-003)

Requirements Preserved

All display-only requirements remain intact:

  • REQ-UI-001: Information-only displays for mount status visualization
  • REQ-UI-002: LCD screen support (small, large, color, monochrome)
  • REQ-UI-003: Mount status information display when display present

Architecture Impact

The firmware architecture now focuses exclusively on:

  • Display-only output for status visualization
  • LX200 protocol for all control operations
  • Web-based configuration interface for device setup
  • No local interactive input devices for simplified hardware requirements

This change simplifies the user interface architecture while maintaining full functionality through established control protocols and modern web-based configuration.

Fixes #28.
Fixes #29.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

- Updated Section 11 title from "USER INTERFACE REQUIREMENTS" to "DISPLAY REQUIREMENTS"
- Removed Section 11.2 "Input Device Requirements" (REQ-UI-004 through REQ-UI-007)
- Removed Section 11.3 "Interactive Operations Requirements" (REQ-UI-008 through REQ-UI-012)
- Updated ROADMAP.md EPIC 7.1 to focus only on display support
- Updated design.md cross-references to reflect removed requirements
- Preserved all display-only requirements (REQ-UI-001 through REQ-UI-003)

Co-authored-by: andre-stefanov <4808362+andre-stefanov@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove interactive input device requirements from specifications Remove interactive input device requirements from specifications Aug 3, 2025
Copilot AI requested a review from andre-stefanov August 3, 2025 09:09
@andre-stefanov andre-stefanov marked this pull request as ready for review August 3, 2025 10:07
Copilot AI review requested due to automatic review settings August 3, 2025 10:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all interactive input device requirements from the firmware specifications, simplifying the user interface architecture to focus solely on display-only output and protocol-based control. This aligns with an architectural decision to eliminate local interactive controls in favor of LX200 protocol commands and web-based configuration interfaces.

Key Changes:

  • Removed 9 requirements related to interactive input devices (buttons, joysticks, encoders, touchscreens)
  • Updated section titles to reflect display-only focus
  • Preserved all display requirements for status visualization

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
specs/requirements.md Removed input device and interactive operations requirements sections, updated section title to "Display Requirements"
specs/design.md Updated requirement cross-references to reflect only preserved display requirements
ROADMAP.md Updated EPIC 7 title and scope, removed interactive input device acceptance criteria

@andre-stefanov andre-stefanov enabled auto-merge (squash) August 3, 2025 10:08
@andre-stefanov andre-stefanov disabled auto-merge August 3, 2025 10:14
@andre-stefanov andre-stefanov merged commit 8579c5d into main Aug 3, 2025
5 checks passed
@andre-stefanov andre-stefanov deleted the copilot/fix-28 branch August 3, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update roadmap to remove interactive input device support Remove interactive input device requirements from specifications

2 participants