Skip to content

Conversation

@feltech
Copy link
Member

@feltech feltech commented Nov 9, 2022

Closes #2. This will allow dependent projects such as https://github.com/OpenAssetIO/OpenAssetIO-MediaCreation to automate its use as part of their build pipeline.

Build wheels on PR or and merge to main. Publish wheels built on main for release. Waiting for wheels to be built before publishing, if not already (see concurrency.group in the .yml files).

@feltech feltech requested a review from elliotcmorris November 9, 2022 17:30
@feltech feltech self-assigned this Nov 9, 2022
@feltech feltech marked this pull request as draft November 9, 2022 17:41
@feltech
Copy link
Member Author

feltech commented Nov 9, 2022

Converted to Draft since after doing a test publish (on my fork) the TestPyPI page includes the whole README, a lot of which assumes you've cloned the repo. So we either need a separate README or to massage the existing README to work in multiple contexts.

TraitGen is now a separate project, so the relative path link was
broken.

Signed-off-by: David Feltell <david.feltell@foundry.com>
In particular, this is useful in preparation for PyPI publishing in #2,
where (parts of) the README will be published independently of the repo.

Signed-off-by: David Feltell <david.feltell@foundry.com>
@feltech feltech force-pushed the work/2-publishPyPI branch 5 times, most recently from 38b36f9 to aa06754 Compare November 10, 2022 11:11
@feltech
Copy link
Member Author

feltech commented Nov 10, 2022

Converted to Draft since after doing a test publish (on my fork) the TestPyPI page includes the whole README, a lot of which assumes you've cloned the repo. So we either need a separate README or to massage the existing README to work in multiple contexts.

Updated. I screwed up for the first couple of test releasees and didn't add a .dev suffix, so unfortunately we have to start at 1.0.0a3, apologies.

TestPyPI release: https://test.pypi.org/project/openassetio-traitgen/

@feltech feltech marked this pull request as ready for review November 10, 2022 11:13
Copy link
Contributor

@elliotcmorris elliotcmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fab. One super minor note.

Closes #2. This will allow dependent projects such as
https://github.com/OpenAssetIO/OpenAssetIO-MediaCreation to automate its
use as part of their build pipeline.

Build wheels on PR or and merge to `main`. Publish wheels built on
`main` for release. Waiting for wheels to be built before publishing, if
not already (see `concurrency.group` in the `.yml` files).

Signed-off-by: David Feltell <david.feltell@foundry.com>
@elliotcmorris elliotcmorris merged commit 9331270 into OpenAssetIO:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish openassetio-traitgen to PyPI

2 participants