Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slime Boss - Code #2176

Merged
merged 22 commits into from
May 12, 2018
Merged

Conversation

TideSofDarK
Copy link
Contributor

No description provided.

@l34Um1
Copy link
Collaborator

l34Um1 commented Apr 22, 2018

Shake isn't supposed to make the boss invincible. It shouldn't be interruptable though. It should also instantly show where the projectiles are going to land and it should last longer with each cycle having projectiles going to a new location.

@TideSofDarK
Copy link
Contributor Author

Please explain "last longer" part. You mean this stunned condition?

@l34Um1
Copy link
Collaborator

l34Um1 commented Apr 22, 2018

Currently it is one cycle long with that cycle lasting maybe a second (not sure how long exactly). The ability should last ~6 seconds with multiple cycles. The longer the duration the more cycles.

@TideSofDarK
Copy link
Contributor Author

So it shouldnt be single burst and projectiles should appear consequentially in groups of like 6 or smth, right?

@l34Um1
Copy link
Collaborator

l34Um1 commented Apr 22, 2018

Yes

@TideSofDarK
Copy link
Contributor Author

Here it is. Projectile number, delay etc, everything, can be adjusted in ability kv.

@l34Um1
Copy link
Collaborator

l34Um1 commented Apr 22, 2018

I just had the boss split after using shake even though it had taken no damage. Also, the AI is not working for me. Shake is good now though.

I'm also getting this popup. Not sure what it is.
unbenannt

- Added all of swiper's effects for his different actions
@TideSofDarK
Copy link
Contributor Author

@l34Um1 did you spawn it using console? chris asked me to make it work using bosses.lua, and that way it adds BossTier variable to boss on spawn. ai is not working if its not set
i will make a workaround to all my bosses now

@l34Um1
Copy link
Collaborator

l34Um1 commented Apr 22, 2018

Oh, I'm just spawning using cheats. Can you explain to me how to spawn them with console?

@TideSofDarK
Copy link
Contributor Author

TideSofDarK commented Apr 22, 2018

It should work with cheats now.
dota_create_unit npc_dota_boss_slime enemy is console command

@carlosrpg
Copy link
Collaborator

@TideSofDarK
on \game\scripts\vscripts\components\boss\spawn.lua ln 86 :
BossSpawner:SpawnBoss(pit, bossName, bossTier, isProtected)
replace bossName for your boss name.

On \game\scripts\vscripts\settings.lua

BOSS_RESPAWN_START replace BOSS_RESPAWN_START for 0 if you want the boss to spawn immediatly.

TideSofDarK and others added 3 commits April 23, 2018 02:24
- Doubled the size of all ieffects
- Improved alpha fade in/out and general transparency
- Fixed rotation issues with frontswipe and backswipe
- Improved Thrust and Rush alignments & Sword placement/rotation
- Generally improved overall visuals & clarity of all effects
@l34Um1
Copy link
Collaborator

l34Um1 commented Apr 23, 2018

The Boss doesn't do shake before split. Also when splitting, I get this:

unbenannt

Other than that it seems done.

@TideSofDarK
Copy link
Contributor Author

don't other bosses start same spam on death?

@l34Um1
Copy link
Collaborator

l34Um1 commented Apr 23, 2018

Not for me.

@TideSofDarK
Copy link
Contributor Author

Fixed both things

@l34Um1
Copy link
Collaborator

l34Um1 commented Apr 23, 2018

Please make him invincible during the shake before a split, but only during that one. Then we are done and I think this can be merged.

@TideSofDarK
Copy link
Contributor Author

done

@carlosrpg
Copy link
Collaborator

@l34Um1 do you want to mege this before the model is done? if so, which model do you have in mind?
also, which tier it will be?

@l34Um1
Copy link
Collaborator

l34Um1 commented Apr 24, 2018

Yes. Isn't there a siltbreaker slime boss model? Tier is in the issue for the bosses

@carlosrpg
Copy link
Collaborator

Why do the Swiper particles are in this PR? can you remove them?

@TideSofDarK
Copy link
Contributor Author

Should be fine

thisEntity.hJumpAbility = thisEntity:FindAbilityByName( "boss_slime_jump" )
thisEntity.hSlamAbility = thisEntity:FindAbilityByName( "boss_slime_slam" )
thisEntity.hShakeAbility = thisEntity:FindAbilityByName( "boss_slime_shake" )
-- thisEntity.hReapersRushAbility = thisEntity:FindAbilityByName( "boss_swiper_reapers_rush" )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it

local unitName = caster:GetUnitName()

local function CreateClone(origin)
local clone = CreateUnitByName(unitName, origin, true, nil, nil, caster:GetTeamNumber())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to copy the items from the parent, so the copies have heart and the core.
also if you are in fact killing/let the original one die you have to create a spawner unit that will die only when all the splits die as well, otherwise it will not reward the core or reward the core on the first phase kill.

take a look at npc_dota_creature_temple_guardian_spawner

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"DOTAUnits"
{
//=================================================================================
// Boss tier ?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 2

@l34Um1
Copy link
Collaborator

l34Um1 commented May 2, 2018

Tides you gonna do the changes carlos requested?

@TideSofDarK
Copy link
Contributor Author

Yeah sure

@TideSofDarK
Copy link
Contributor Author

@l34Um1 imo ready to be merged

if thisEntity == nil then
return
end
thisEntity.bForceKill = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whitespace in this file is insane, go through and fix up the indentation. Using an editor that supports .editorconfig will help a lot.

@carlosrpg carlosrpg merged commit b71d9f7 into OpenAngelArena:master May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants