added openadapt.renew #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dm
commented
May 30, 2023
| src | ||
| .DS_Store |
There was a problem hiding this comment.
I always have to ignore the .DS_Store file on Mac 😅
0dm
commented
May 30, 2023
openadapt/renew.py
Outdated
| db = getenv_fallback("DB_FNAME") | ||
| if os.path.exists(db): | ||
| os.remove(db) | ||
| result = run(["alembic", "upgrade", "head"], stderr=PIPE, text=True) |
There was a problem hiding this comment.
prevents duplicate logging of config
should have probably commented the code 🥲
|
Thanks @0dm ! @Mustaballer is working on something similar for exporting databases, perhaps it makes sense to consolidate this logic (perhaps not). Can you please move |
|
new usage: |
|
@abrichr ready again |
abrichr
reviewed
Jun 2, 2023
abrichr
reviewed
Jun 14, 2023
|
implemented in #135 |
|
nevermind, there's a small change that needs to be merged (use config.DB_FPATH rather than getenv_fallback) |
R-ohit-B-isht
pushed a commit
to R-ohit-B-isht/OpenAdapt
that referenced
this pull request
Jun 21, 2024
added openadapt.renew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purpose: removes existing database file and runs alembic migrations
usage:
python3 -m openadapt.renewI find this pretty useful and like it more than typing
rm openadapt.db && alembic upgrade head- and it's more pythonic..I also added a definition for DB_FNAME because my linter was reporting an issue here: