Fix atomacos in requirements.txt

[abrichr]

Solution:

Modify this line:

-e git+https://github.com/abrichr/atomacos.git; sys_platform == 'darwin'

To:

-e git+https://github.com/abrichr/atomacos.git#atomacos ; sys_platform == 'darwin'

[KrishPatel13]

After fixing that, while pip install -r requiements.txt --no-cache-dir

I encountered this:

I have tried: #40 (comment)

I have latest setuptools, wheel, pip libraries.

[KrishPatel13]

This is my current requirements.txt:

alembic==1.8.1
ascii_magic==2.3.0
-e git+https://github.com/abrichr/atomacos.git#egg=atomacos ; sys_platform == 'darwin'
bokeh==2.4.3
clipboard==0.0.4
deepdiff[optimize]==6.3.0
dictalchemy3==1.0.0
fire==0.4.0
ipdb==0.13.11
loguru==0.6.0
matplotlib==3.6.2
mss==6.1.0
openai==0.27.5
pandas==2.0.0
pygetwindow==0.0.9; sys_platform == 'win32'
pyinstaller
setuptools-lint
sphinx
python-dotenv==1.0.0
pywin32==306; sys_platform == 'win32'
-e git+https://github.com/abrichr/pynput.git#egg=pynput
pytest==7.1.3
rapidocr-onnxruntime==1.2.3
scikit-learn==1.2.2
scipy==1.9.3
sqlalchemy==1.4.43
tiktoken==0.4.0
torch==2.0.0
tqdm==4.64.0
transformers==4.28.1

[KrishPatel13]

I am using Windows OS

[KrishPatel13]

After fixing that, while pip install -r requiements.txt --no-cache-dir

I encountered this:

I have tried: [#40 (comment)](https://github.com//issues/40#issuecomment-1528350805)

I have latest setuptools, wheel, pip libraries.

Looks like it is installing atomacos even if my os is windows that means the test condition
sys_platform == 'darwin' is failing or not executing

[KrishPatel13]

A simple solutions that fixed it is:

Solution:

Modify this line:

-e git+https://github.com/abrichr/atomacos.git ; sys_platform == 'darwin'

To:

git+https://github.com/abrichr/atomacos.git; sys_platform == 'darwin'

But will this work for Mac OS as well ? As our idea is to have the editable tag -e but that will give error in windows as with editable it looks like it does not test the condition sys_platform == 'darwin'

[abrichr]

If you recall, we needed to add #atomacos to this line in order for it not to fail on your machine.

The fact that it was failing is itself an issue, since pip should know not to install it due to the sys_platform.

Can you please figure out how to specify #atomacos for sys_platform == 'darwin'?

[KrishPatel13]

I added #atomacos
-e git+https://github.com/abrichr/atomacos.git#atomacos ; sys_platform == 'darwin'

On installing even this gave error as below:
ERROR: Could not detect requirement name for 'git+https://github.com/abrichr/atomacos.git#atomacos', please specify one with #egg=your_package_name

On changing to:
-e git+https://github.com/abrichr/atomacos.git#egg=atomacos ; sys_platform == 'darwin'

This gave the error:

Collecting pyobjc-core>=3.0.4 (from atomacos->-r .\requirements.txt (line 3))
  Downloading pyobjc-core-9.1.1.tar.gz (896 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 896.1/896.1 kB 2.4 MB/s eta 0:00:00        
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [2 lines of output]
      running egg_info
      error: PyObjC requires macOS to build
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.   
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

[KrishPatel13]

I figured a way out and it ignored for windows:

atomacos @ git+https://github.com/abrichr/atomacos.git#egg=atomacos ; sys_platform == 'darwin'

Will this work for macOs ?

[abrichr]

Thanks @KrishPatel13 ! Can we keep the -e?

Please reach out to @0dm to verify this works on MacOS 🙏

[KrishPatel13]

With -e

as I said it ignores the sys_platform='darwin'. So it tries to install that too for Windows and thus results in the error.

I have researched online no where I can find an error similar to this where they have used -e and they got similar errors with the platformconditionals.

[KrishPatel13]

If this PR is closed with merging, then we can close this issue.

#211 (comment)