Skip to content

Conversation

@JFCote
Copy link
Member

@JFCote JFCote commented Jan 22, 2021

This is to fix #148 in a global way. I also removed old deprecated stuff since we release a couple of version since then.

@JFCote JFCote requested a review from jmini January 22, 2021 19:14
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #153 (51a4812) into master (5b417a9) will increase coverage by 0.78%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #153      +/-   ##
============================================
+ Coverage     51.74%   52.52%   +0.78%     
- Complexity      145      167      +22     
============================================
  Files            16       16              
  Lines           543      672     +129     
  Branches         96      126      +30     
============================================
+ Hits            281      353      +72     
- Misses          227      281      +54     
- Partials         35       38       +3     
Impacted Files Coverage Δ Complexity Δ
...pitools/openapistylevalidator/NamingValidator.java 61.29% <50.00%> (-4.23%) 17.00 <1.00> (+1.00) ⬇️
...ols/openapistylevalidator/ValidatorParameters.java 82.60% <100.00%> (+0.36%) 50.00 <0.00> (+12.00)
...pitools/openapistylevalidator/ErrorAggregator.java 40.62% <0.00%> (-1.69%) 6.00% <0.00%> (+1.00%) ⬇️
...napistylevalidator/styleerror/ModelStyleError.java 100.00% <0.00%> (ø) 13.00% <0.00%> (+1.00%)
...ylevalidator/gradle/OpenAPIStyleValidatorTask.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...enapistylevalidator/OpenApiSpecStyleValidator.java 59.88% <0.00%> (+8.52%) 30.00% <0.00%> (+7.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b417a9...51a4812. Read the comment docs.

@JFCote JFCote removed the request for review from jmini February 23, 2021 20:00
Copy link
Collaborator

@blakthorn666 blakthorn666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor issue was found.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JFCote JFCote merged commit c1eb989 into master Feb 24, 2021
@JFCote JFCote deleted the add-anycase-to-ignore-naming branch February 24, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Header definition clashing with naming conventions

3 participants