Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Spring] Additional annotations with String params #7117

Merged

Conversation

borsch
Copy link
Member

@borsch borsch commented Aug 3, 2020

Implementation for #7116

PR checklist

  • [+] Read the contribution guidelines.
  • [+] If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • [+] Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [+] File the PR against the correct branch: master
  • [+] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@borsch borsch force-pushed the additional-annotations-with-string-params branch from 4e8ed62 to bf166fc Compare August 3, 2020 14:01
@borsch borsch changed the title Additional annotations with String params [REQ][Java] Additional annotations with String params Aug 3, 2020
@borsch
Copy link
Member Author

borsch commented Aug 4, 2020

@wing328 @jimschubert could you please review this small change

@borsch borsch requested a review from wing328 August 10, 2020 17:46
@borsch
Copy link
Member Author

borsch commented Aug 12, 2020

@wing328 @jimschubert could you please please review

@wing328
Copy link
Member

wing328 commented Aug 12, 2020

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit c9939a2 into OpenAPITools:master Aug 12, 2020
@wing328 wing328 changed the title [REQ][Java] Additional annotations with String params [Java][Spring] Additional annotations with String params Aug 12, 2020
@wing328 wing328 added this to the 5.0.0 milestone Aug 12, 2020
@borsch borsch deleted the additional-annotations-with-string-params branch January 30, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants