Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust][client] fix enum type usage #4859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qavvvzdhwm
Copy link

@qavvvzdhwm qavvvzdhwm commented Dec 22, 2019

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

PR description

The model template was referring to the enum name in the context instead of the enum-updated type.

openapi: 3.0.0
info:
  title: rust array of enums bug
  version: 1.0.0
paths:
  /:
    get:
      operationId: Op1
      tags:
        - array-enum
      responses:
        "200":
          description: ""
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/ResponseFizzesBuzzes"
      requestBody:
        content:
          application/json:
            schema:
              type: integer
components:
  schemas:
    ResponseFizzesBuzzes:
      type: object
      properties:
        fizzes_buzzes:
          type: array
          items:
            type: string
            enum:
              - fizz
              - buzz
              - fizz_buzz
      required:
        - fizzes_buzzes

generated originally:

    pub fizzes_buzzes: FizzesBuzzes,

fixed:

    pub fizzes_buzzes: Vec<FizzesBuzzes>,

cc: @frol, @farcaller, @bjgill, @richardwhiuk

@auto-labeler
Copy link

auto-labeler bot commented Dec 22, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@qavvvzdhwm qavvvzdhwm force-pushed the rust-enum-type branch 3 times, most recently from 15c1a4b to 73cc977 Compare December 23, 2019 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant