fix(typescript-angular): do not call .toISOString() on a string (#4330) #4337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for your pr especially, you need to re-generate the samples and commit the changes: |
|
No problem. I've ran the command and it did not produce any changes. |
jimschubert
added a commit
that referenced
this pull request
Nov 3, 2019
* 'master' of github.com:OpenAPITools/openapi-generator: (88 commits) smaller tests, better code format (#4355) csharp-netcore: Replace null literals with default (#4345) [core] consider polymorphism when computing unused schemas (#4335) Fix issue 4326 forward throws for delegate to main method (#4327) [kotlin][client] annotate api exceptions (#4339) refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353) Remove deprecated API use of ObjectFactory.property() (#2613) (#4352) [python][metadata]: Adding license and author fields (#4318) [Python] Avoid pep8 violation (#4316) [JS] Update package.json (#4261) Add slash-arun to Python technical committee (#4354) [typescript-fetch] Fix discriminator mapping name (#4340) fix security alerts reported by github (#4344) fix cpp-restbed-server json field serialization #4320 (#4323) typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341) fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337) update samples (#4334) Prepare 4.2.0 release (#4333) [FEATURE][Haskell] Haskell-Servant serves static files (#4058) [FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056) ...
jimschubert
added a commit
that referenced
this pull request
Nov 3, 2019
* master: (142 commits) smaller tests, better code format (#4355) csharp-netcore: Replace null literals with default (#4345) [core] consider polymorphism when computing unused schemas (#4335) Fix issue 4326 forward throws for delegate to main method (#4327) [kotlin][client] annotate api exceptions (#4339) refactor java-vertx-web parameters and bugfix on non primitive parameter (#4353) Remove deprecated API use of ObjectFactory.property() (#2613) (#4352) [python][metadata]: Adding license and author fields (#4318) [Python] Avoid pep8 violation (#4316) [JS] Update package.json (#4261) Add slash-arun to Python technical committee (#4354) [typescript-fetch] Fix discriminator mapping name (#4340) fix security alerts reported by github (#4344) fix cpp-restbed-server json field serialization #4320 (#4323) typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (#4341) fix(typescript-angular): do not call .toISOString() on a string (#4330) (#4337) update samples (#4334) Prepare 4.2.0 release (#4333) [FEATURE][Haskell] Haskell-Servant serves static files (#4058) [FEATURE][Haskell] Add Middleware support for the haskell servant generator (#4056) ...
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Nov 3, 2019
* master: (141 commits) smaller tests, better code format (OpenAPITools#4355) csharp-netcore: Replace null literals with default (OpenAPITools#4345) [core] consider polymorphism when computing unused schemas (OpenAPITools#4335) Fix issue 4326 forward throws for delegate to main method (OpenAPITools#4327) [kotlin][client] annotate api exceptions (OpenAPITools#4339) refactor java-vertx-web parameters and bugfix on non primitive parameter (OpenAPITools#4353) Remove deprecated API use of ObjectFactory.property() (OpenAPITools#2613) (OpenAPITools#4352) [python][metadata]: Adding license and author fields (OpenAPITools#4318) [Python] Avoid pep8 violation (OpenAPITools#4316) [JS] Update package.json (OpenAPITools#4261) Add slash-arun to Python technical committee (OpenAPITools#4354) [typescript-fetch] Fix discriminator mapping name (OpenAPITools#4340) fix security alerts reported by github (OpenAPITools#4344) fix cpp-restbed-server json field serialization OpenAPITools#4320 (OpenAPITools#4323) typescript-angular: fix oneOf and anyOf generates incorrect model for primitive types (OpenAPITools#4341) fix(typescript-angular): do not call .toISOString() on a string (OpenAPITools#4330) (OpenAPITools#4337) update samples (OpenAPITools#4334) Prepare 4.2.0 release (OpenAPITools#4333) [FEATURE][Haskell] Haskell-Servant serves static files (OpenAPITools#4058) [FEATURE][Haskell] Add Middleware support for the haskell servant generator (OpenAPITools#4056) ...
|
@malymato thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4330, analogous to #3423.