[csharp][generichost] Better file support #22806
Draft
+10,848
−328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MultipartFormDataContent Generation for File Uploads in C# GenericHost
Summary
This PR fixes critical issues with multipart file upload code generation in the C# GenericHost library. The generated code now correctly handles single files, arrays of files, and mixed form parameters.
Closes
Changes
Issues Fixed
Content-Type Header: Changed from
MultipartContent(multipart/mixed) toMultipartFormDataContent(multipart/form-data) to match OpenAPI specificationsArray of Files Support: Added proper iteration logic for file parameters that are arrays/containers
Proper Field Names: Files now use their actual parameter names instead of hardcoded values, allowing servers to correctly parse form fields
Conditional FormUrlEncodedContent: Only adds
FormUrlEncodedContentwhen there are actual non-file form parameters, preventing empty content additionsContent Assignment Order:
httpRequestMessageLocalVar.Contentis now assigned after the multipart content is fully populated, improving code clarity and reliabilityGenerated Code Behavior
Before:
After:
Testing
Generated code now:
Files Modified
modules/openapi-generator/src/main/resources/csharp/libraries/generichost/api.mustache- Updated file parameter handling in request building logicPR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds correct multipart/form-data handling and multi-file upload support to C# GenericHost clients. Fixes broken file parameter generation and updates tests/samples to validate single and multiple file uploads. Fixes #21380 and #21449.
New Features
Bug Fixes
Written for commit ff5bd0b. Summary will update on new commits.