Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jan 18, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixed R client error handling to return consistent ApiResponse objects with content, response, and status_code. Corrected empty-response checks to handle vector values and updated generated R samples.

  • Bug Fixes
    • Construct ApiResponse with named fields and include status_code in non-2xx branches.
    • Standardize messages: 3xx uses “Server returned …”, 4xx uses “API client error”, 5xx falls back to “API server error” only when response is NULL or all empty.
    • Use all(local_var_resp$response == "") to avoid logical vector issues; regenerate echo_api and petstore R samples.

Written for commit c81729d45ada6558e58696f830f2ea50c3a92da9. Summary will update on new commits.

@wing328 wing328 closed this Jan 18, 2026
@wing328 wing328 deleted the mattpollock-fix/r-client-error-handling branch January 18, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants