Skip to content

Conversation

@exviva
Copy link
Contributor

@exviva exviva commented Nov 10, 2025

When an array property has enum integer items, the kotlin codegen would generate invalid code, e.g.:

    /**
     * 
     *
     * Values: _0,_1,_2,_3,_4,_5,_6
     */
    enum class DaysOfWeek(val value: kotlin.String) { // <---- value is of type String
        @JsonProperty(value = "0") _0(0), // <---- but Ints are being passed to constructor
        @JsonProperty(value = "1") _1(1),
        @JsonProperty(value = "2") _2(2),
        @JsonProperty(value = "3") _3(3),
        @JsonProperty(value = "4") _4(4),
        @JsonProperty(value = "5") _5(5),
        @JsonProperty(value = "6") _6(6);
    }

With the fix, the code is generated correctly:

    /**
     *
     *
     * Values: _0,_1,_2,_3,_4,_5,_6
     */
    enum class DaysOfWeek(val value: kotlin.Int) {
        @JsonProperty(value = "0") _0(0),
        @JsonProperty(value = "1") _1(1),
        @JsonProperty(value = "2") _2(2),
        @JsonProperty(value = "3") _3(3),
        @JsonProperty(value = "4") _4(4),
        @JsonProperty(value = "5") _5(5),
        @JsonProperty(value = "6") _6(6);
    }

I was following the Java codegen.

Fixes #15204.

@karismann @Zomzog @andrewemery @4brunu @stefankoppier @e5l

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Nov 11, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@exviva exviva force-pushed the fix-15204-kotlin-invalid-enum-int-array branch from 1723b87 to 9dbd77f Compare November 11, 2025 11:24
@exviva
Copy link
Contributor Author

exviva commented Nov 11, 2025

@wing328 thanks for the review! You're right, I was on my work account -- amended.

@wing328
Copy link
Member

wing328 commented Nov 11, 2025

lgtm. let's give it a try

thanks for the contribution

@wing328 wing328 merged commit 2ab5365 into OpenAPITools:master Nov 11, 2025
14 checks passed
@wing328 wing328 added this to the 7.18.0 milestone Nov 11, 2025
@exviva
Copy link
Contributor Author

exviva commented Nov 11, 2025

lgtm. let's give it a try

Thanks @wing328, appreciate it! Do we have an ETA for a 7.18.0 release?

@wing328
Copy link
Member

wing328 commented Nov 12, 2025

please refer to milestones

@wing328
Copy link
Member

wing328 commented Nov 12, 2025

FYI. Merged #22336 to add a test covering this moving forward

@exviva exviva deleted the fix-15204-kotlin-invalid-enum-int-array branch November 12, 2025 08:50
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Kotlin] Enum with Int values generated to hold String

2 participants