Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Sep 6, 2025

a follow up pr to #21899

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 marked this pull request as ready for review September 6, 2025 14:48
@wing328 wing328 merged commit e62908e into master Sep 6, 2025
9 of 14 checks passed
@wing328 wing328 deleted the go-test-withxml branch September 6, 2025 14:49
@wing328 wing328 added this to the 7.16.0 milestone Sep 6, 2025

// Pet A pet for sale in the pet store
type Pet struct {
Id *int64 `json:"id,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xml attributes are missing

@sruehl
Copy link
Contributor

sruehl commented Sep 8, 2025

@wing328 seems almost good besides a flipped boolean.

Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
@sruehl sruehl mentioned this pull request Nov 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants