[rust-axum] Prevent multiple declarations of the same operation#21396
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jun 16, 2025
Merged
[rust-axum] Prevent multiple declarations of the same operation#21396wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Member
|
thanks for the pr cc @linxGnu |
linxGnu
reviewed
Jun 16, 2025
Contributor
linxGnu
left a comment
There was a problem hiding this comment.
Almost LGTM.
Could you please re-run integration test with following commands:
./bin/generate-samples.sh bin/configs/manual/rust-axum-*
mvn integration-test -f samples/server/petstore/rust-axum/pom.xml
Member
did these locally and the result is good |
Member
|
FYI. another way to address similar issue is to use the ref: https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If tags are defined for an operation, the router path will be duplicated per tag. If a security schema is defined as well, the code will no longer compile because there will be duplicate operations with and without a claims parameter. Since there doesn't appear to be a benefit to specifying the same operation multiple times, this skips adding an operation if it already exists.
Fixes #21144
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)